Skip to content

Commit bf6e485

Browse files
authored
fix(toolkit): flaky test cases (#8327)
## Problem - https://d1ihu6zq92vp9p.cloudfront.net/45451b0f-383e-4f4a-adc0-ce623f5765be/report.html ``` Error: Activating extension 'redhat.java' failed: Java 21 or more recent is required to run the Java extension. Please download and install a recent JDK. You can still compile your projects with older JDKs by configuring ['java.configuration.runtimes'](https://github.com/redhat-developer/vscode-java/wiki/JDK-Requirements#java.configuration.runtimes). at v.n (/tmp/.vscode-test/vscode-linux-x64-1.83.0/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:125:6274) at async v.m (/tmp/.vscode-test/vscode-linux-x64-1.83.0/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:125:6168) at async v.l (/tmp/.vscode-test/vscode-linux-x64-1.83.0/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:125:5625) ``` - The Python 3.14 version is coming from the external Serverless Land repository pattern (aws-samples/serverless-patterns) ## Solution - Fixed tests --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent c8809c6 commit bf6e485

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

packages/core/scripts/test/launchTestUtilities.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ async function getVSCodeCliArgs(params: {
121121
['DEVELOPMENT_PATH']: projectRootDir,
122122
['AWS_TOOLKIT_AUTOMATION']: params.suite,
123123
['TEST_DIR']: process.env.TEST_DIR,
124+
['JAVA_HOME']: process.env.JAVA_HOME,
124125
...params.env,
125126
},
126127
}

packages/core/src/test/awsService/appBuilder/serverlessLand/wizard.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ describe('CreateWizard', async () => {
8888
assert.ok(resourceNodes[0] instanceof ResourceNode)
8989

9090
const lambdaResource = resourceNodes[2] as ResourceNode
91-
assert.strictEqual(lambdaResource.resource.resource.Runtime, 'python3.12')
91+
assert.strictEqual(lambdaResource.resource.resource.Runtime, 'python3.14')
9292

9393
prompterTester.assertCallAll()
9494
})

0 commit comments

Comments
 (0)