chore: add 8.5 support #3179
Merged
chore: add 8.5 support #3179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stobrien89
force-pushed
the
8.5-support
branch
26 times, most recently
from
fc5c30c to
116c59b
Compare
1 task
stobrien89
force-pushed
the
8.5-support
branch
from
116c59b to
85cce0f
Compare
stobrien89
force-pushed
the
8.5-support
branch
17 times, most recently
from
449cc4e to
4caa0f3
Compare
yenfryherrerafeliz
requested changes
Nov 28, 2025
Contributor
yenfryherrerafeliz
left a comment
yenfryherrerafeliz
left a comment
There was a problem hiding this comment.
I think falling back to empty string in every array access could be problematic, but we can leave this open for discussion.
| public function testDownloadsObjectsWithAccessPointArn() | ||
| { | ||
| if (PHP_OS_FAMILY === 'Windows') { | ||
| $this->markTestSkipped('S3 access point ARN downloads have path handling issues on Windows'); |
Contributor
There was a problem hiding this comment.
What does this mean?, customers can't do downloads using access points ARNs on Windows then?
Member
Author
There was a problem hiding this comment.
possibly. Will need to add to the backlog to investigate. I tried for a while to get this working
stobrien89
force-pushed
the
8.5-support
branch
from
4caa0f3 to
b505e38
Compare
stobrien89
force-pushed
the
8.5-support
branch
from
b505e38 to
0689e4b
Compare
yenfryherrerafeliz
requested changes
Dec 2, 2025
Contributor
yenfryherrerafeliz
left a comment
yenfryherrerafeliz
left a comment
There was a problem hiding this comment.
Looks good. Just minor nits and some questions.
stobrien89
force-pushed
the
8.5-support
branch
from
0689e4b to
a06da94
Compare
yenfryherrerafeliz
requested changes
Dec 2, 2025
Contributor
yenfryherrerafeliz
left a comment
yenfryherrerafeliz
left a comment
There was a problem hiding this comment.
Just some minor questions.
yenfryherrerafeliz
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #2941, #3217
Description of changes:
Fixes PHP 8.5 deprecation warnings and adds 8.5 to test runs, adds Windows unit test workflow, adds JIT to applicable workflows, adds separate Codecov coverage workflow that runs weekly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.