Skip to content

Sqs AwsJson migration #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Sqs AwsJson migration #3329

wants to merge 2 commits into from

Conversation

ziyanli-amazon
Copy link
Contributor

@ziyanli-amazon ziyanli-amazon commented Jul 28, 2022

Add awsQueryCompatible trait support to service
SEP: https://code.amazon.com/reviews/CR-73314020

Motivation and Context

When awsQueryCompatible trait is found, it's made available as an API property. When this property is found,
the error code is returned by looking up the mapping. This is a pre-requisite for migrating services from
AWSQuery wire protocol to AWSJson.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@ziyanli-amazon ziyanli-amazon marked this pull request as ready for review August 10, 2022 22:52
@ziyanli-amazon ziyanli-amazon requested a review from a team as a code owner August 10, 2022 22:52
@ziyanli-amazon ziyanli-amazon marked this pull request as draft August 10, 2022 22:53
@ziyanli-amazon ziyanli-amazon marked this pull request as ready for review August 10, 2022 22:59
@ziyanli-amazon
Copy link
Contributor Author

This migration plan was abandoned and new plan will take effect in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant