Skip to content

Improve and add new operation S3Client #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
eddumelendez opened this issue Apr 3, 2021 · 1 comment
Closed
1 task

Improve and add new operation S3Client #2372

eddumelendez opened this issue Apr 3, 2021 · 1 comment
Labels
feature-request A feature should be added or improved.

Comments

@eddumelendez
Copy link

Currently, I am working on spring cloud aws integration with s3, moving the existing implementation from sdk v1 to v2 and I would like to perform some operations in a friendly way. In this case, if the user is working with buckets use S3Bucket and if it is using objects then use S3Object instead of *Response classes.

Describe the Feature

Is your Feature Request related to a problem?

Proposed Solution

Currently, there is a model class S3Object, would be great to have a similar one for S3Bucket which contains information about the bucket and can be use it when performing this.s3Client.createBucket(CreateBucketRequest.builder().build()). Also, add a new method this.s3Client.getBucket(GetBucketRequest); which also return S3Bucket.

Describe alternatives you've considered

Additional Context

  • I may be able to implement this feature request

Your Environment

  • AWS Java SDK version used: 2.16.1
  • JDK version used: 11
  • Operating System and version:
@eddumelendez eddumelendez added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 3, 2021
@debora-ito
Copy link
Member

@eddumelendez Same case of #2371, this change would need to be made upstream in the S3 service model. Changing the current createBucket operation would be a breaking change though, a new operation would need to be created. And headBucket is the operation equivalent to getBucket but it does not return a S3Bucket.

I'll close this for now, feel free to reach out with more discussions about the Spring integration.

@debora-ito debora-ito removed the needs-triage This issue or PR still needs to be triaged. label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants