Merge pull request #27 from awslabs/FB-ExecutorFix

bretambrose · web-flow · commit aef44b9faeaf · 2016-09-21T09:16:12.000-07:00
Fix comparison operator in REJECT_IMMEDIATELY mode check
diff --git a/aws-cpp-sdk-core/source/utils/threading/Executor.cpp b/aws-cpp-sdk-core/source/utils/threading/Executor.cpp
@@ -72,7 +72,7 @@ bool PooledThreadExecutor::SubmitToThread(std::function<void()>&& fn)
     {
         std::lock_guard<std::mutex> locker(m_queueLock);
 
-        if (m_overflowPolicy == OverflowPolicy::REJECT_IMMEDIATELY && m_poolSize >= m_tasks.size())
+        if (m_overflowPolicy == OverflowPolicy::REJECT_IMMEDIATELY && m_tasks.size() >= m_poolSize)
         {
             return false;
         }

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ bool PooledThreadExecutor::SubmitToThread(std::function<void()>&& fn)`
`72`	`72`	`{`
`73`	`73`	`std::lock_guard<std::mutex> locker(m_queueLock);`
`74`	`74`
`75`		`- if (m_overflowPolicy == OverflowPolicy::REJECT_IMMEDIATELY && m_poolSize >= m_tasks.size())`
	`75`	`+ if (m_overflowPolicy == OverflowPolicy::REJECT_IMMEDIATELY && m_tasks.size() >= m_poolSize)`
`76`	`76`	`{`
`77`	`77`	`return false;`
`78`	`78`	`}`