From 42f5b28f2ae153999139e40f1e149a1a1392f8cb Mon Sep 17 00:00:00 2001 From: Mohammed Ehab Date: Wed, 4 Jun 2025 14:34:20 +0300 Subject: [PATCH 1/6] Add missing level_override instance variable to logger #initialize --- lib/aws_lambda_ric/logger_patch.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/aws_lambda_ric/logger_patch.rb b/lib/aws_lambda_ric/logger_patch.rb index 82f2963..158731e 100644 --- a/lib/aws_lambda_ric/logger_patch.rb +++ b/lib/aws_lambda_ric/logger_patch.rb @@ -9,6 +9,7 @@ def initialize(logdev, shift_age = 0, shift_size = 1048576, level: 'debug', if !logdev || logdev == $stdout || logdev == $stderr logdev_lambda_overwrite = AwsLambdaRIC::TelemetryLogger.telemetry_log_sink @default_formatter = LogFormatter.new + @level_override = {} end super(logdev_lambda_overwrite, shift_age, shift_size, level: level, progname: progname, From 32649ecbffdd701a0f359a5e87a9c90dcffc2368 Mon Sep 17 00:00:00 2001 From: Mohammed Ehab Date: Wed, 4 Jun 2025 15:53:27 +0300 Subject: [PATCH 2/6] Fix Formatter Override Being Ignored. --- lib/aws_lambda_ric/logger_patch.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/aws_lambda_ric/logger_patch.rb b/lib/aws_lambda_ric/logger_patch.rb index 158731e..bc3e0f1 100644 --- a/lib/aws_lambda_ric/logger_patch.rb +++ b/lib/aws_lambda_ric/logger_patch.rb @@ -4,16 +4,16 @@ module LoggerPatch def initialize(logdev, shift_age = 0, shift_size = 1048576, level: 'debug', progname: nil, formatter: nil, datetime_format: nil, binmode: false, shift_period_suffix: '%Y%m%d') - logdev_lambda_overwrite = logdev + logdev_lambda_override = logdev + formatter_override = formatter # use unpatched constructor if logdev is a filename or an IO Object other than $stdout or $stderr if !logdev || logdev == $stdout || logdev == $stderr - logdev_lambda_overwrite = AwsLambdaRIC::TelemetryLogger.telemetry_log_sink - @default_formatter = LogFormatter.new - @level_override = {} + logdev_lambda_override = AwsLambdaRIC::TelemetryLogger.telemetry_log_sink + formatter_override = LogFormatter.new end - super(logdev_lambda_overwrite, shift_age, shift_size, level: level, progname: progname, - formatter: formatter, datetime_format: datetime_format, + super(logdev_lambda_override, shift_age, shift_size, level: level, progname: progname, + formatter: formatter_override, datetime_format: datetime_format, binmode: binmode, shift_period_suffix: shift_period_suffix) end end From 1a577f7ceee3b974a9d3ffb252a81c648dc9dc46 Mon Sep 17 00:00:00 2001 From: Mohammed Ehab Date: Thu, 5 Jun 2025 13:03:12 +0300 Subject: [PATCH 3/6] Version Bump to 3.1.1 --- RELEASE.CHANGELOG.md | 4 ++++ lib/aws_lambda_ric/version.rb | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/RELEASE.CHANGELOG.md b/RELEASE.CHANGELOG.md index a0a79ad..7f475d3 100644 --- a/RELEASE.CHANGELOG.md +++ b/RELEASE.CHANGELOG.md @@ -1,3 +1,7 @@ +### May 21, 2025 +`3.1.1` +- Fix Logger Formatting override being ignored. ([#47](https://github.com/aws/aws-lambda-ruby-runtime-interface-client/pull/47)) + ### May 21, 2025 `3.1.0` - Add support for multi tenancy ([#43](https://github.com/aws/aws-lambda-ruby-runtime-interface-client/pull/43)) diff --git a/lib/aws_lambda_ric/version.rb b/lib/aws_lambda_ric/version.rb index e643c8c..a32be95 100644 --- a/lib/aws_lambda_ric/version.rb +++ b/lib/aws_lambda_ric/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module AwsLambdaRIC - VERSION = '3.1.0' + VERSION = '3.1.1' end From dcad73e00bd28fca4873feaf11725c9aa645bae4 Mon Sep 17 00:00:00 2001 From: Mohammed Ehab Date: Thu, 5 Jun 2025 13:37:22 +0300 Subject: [PATCH 4/6] Fix Date --- RELEASE.CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE.CHANGELOG.md b/RELEASE.CHANGELOG.md index 7f475d3..c605c2a 100644 --- a/RELEASE.CHANGELOG.md +++ b/RELEASE.CHANGELOG.md @@ -1,4 +1,4 @@ -### May 21, 2025 +### Jun 5, 2025 `3.1.1` - Fix Logger Formatting override being ignored. ([#47](https://github.com/aws/aws-lambda-ruby-runtime-interface-client/pull/47)) From 9031e0ea1a8d2ec38921ee6cbf8f2437ccc7bff8 Mon Sep 17 00:00:00 2001 From: Mohammed Ehab Date: Thu, 5 Jun 2025 19:17:46 +0300 Subject: [PATCH 5/6] Don't Ignore Custom Formatters. --- RELEASE.CHANGELOG.md | 4 ++++ lib/aws_lambda_ric/logger_patch.rb | 2 +- lib/aws_lambda_ric/version.rb | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/RELEASE.CHANGELOG.md b/RELEASE.CHANGELOG.md index c605c2a..a0ae551 100644 --- a/RELEASE.CHANGELOG.md +++ b/RELEASE.CHANGELOG.md @@ -1,3 +1,7 @@ +### Jun 6, 2025 +`3.1.2` +- Don't Ignore Custom Formatters. ([#48](https://github.com/aws/aws-lambda-ruby-runtime-interface-client/pull/48)) + ### Jun 5, 2025 `3.1.1` - Fix Logger Formatting override being ignored. ([#47](https://github.com/aws/aws-lambda-ruby-runtime-interface-client/pull/47)) diff --git a/lib/aws_lambda_ric/logger_patch.rb b/lib/aws_lambda_ric/logger_patch.rb index bc3e0f1..f872d37 100644 --- a/lib/aws_lambda_ric/logger_patch.rb +++ b/lib/aws_lambda_ric/logger_patch.rb @@ -9,7 +9,7 @@ def initialize(logdev, shift_age = 0, shift_size = 1048576, level: 'debug', # use unpatched constructor if logdev is a filename or an IO Object other than $stdout or $stderr if !logdev || logdev == $stdout || logdev == $stderr logdev_lambda_override = AwsLambdaRIC::TelemetryLogger.telemetry_log_sink - formatter_override = LogFormatter.new + formatter_override = formatter_override || LogFormatter.new end super(logdev_lambda_override, shift_age, shift_size, level: level, progname: progname, diff --git a/lib/aws_lambda_ric/version.rb b/lib/aws_lambda_ric/version.rb index a32be95..8c8c8af 100644 --- a/lib/aws_lambda_ric/version.rb +++ b/lib/aws_lambda_ric/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module AwsLambdaRIC - VERSION = '3.1.1' + VERSION = '3.1.2' end From a55a952770081a845a75436e1bf799a92332e28f Mon Sep 17 00:00:00 2001 From: Mohammed Ehab Date: Thu, 5 Jun 2025 19:25:10 +0300 Subject: [PATCH 6/6] Correct PR Link --- RELEASE.CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE.CHANGELOG.md b/RELEASE.CHANGELOG.md index a0ae551..b3927ae 100644 --- a/RELEASE.CHANGELOG.md +++ b/RELEASE.CHANGELOG.md @@ -1,6 +1,6 @@ ### Jun 6, 2025 `3.1.2` -- Don't Ignore Custom Formatters. ([#48](https://github.com/aws/aws-lambda-ruby-runtime-interface-client/pull/48)) +- Don't Ignore Custom Formatters. ([#49](https://github.com/aws/aws-lambda-ruby-runtime-interface-client/pull/49)) ### Jun 5, 2025 `3.1.1`