Skip to content

fix: events/codedeploy.go:16:2: SA9004 (staticcheck) #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmoffatt merged 4 commits into from
Oct 3, 2020
Merged

fix: events/codedeploy.go:16:2: SA9004 (staticcheck) #322

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
285d478
fix: events/codedeploy.go:16:2: SA9004: only the first constant in th…
shogo82148 Sep 19, 2020
8d23514
Merge branch 'master' into fix-sa9004-codedeploy
bmoffatt Sep 22, 2020
d1a39bb
Merge branch 'master' into fix-sa9004-codedeploy
bmoffatt Oct 3, 2020
61efc90
Merge branch 'master' into fix-sa9004-codedeploy
bmoffatt Oct 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,3 @@ run:
# CodeBuildPhaseTypeSubmitted CodeBuildPhaseType = "SUBMITTED"
# ^
- events/codebuild.go

# FIXME
# events/codedeploy.go:16:2: SA9004: only the first constant in this group has an explicit type (staticcheck)
# CodeDeployDeploymentStateFailure CodeDeployDeploymentState = "FAILURE"
# ^
- events/codedeploy.go
8 changes: 4 additions & 4 deletions events/codedeploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ type CodeDeployDeploymentState string

const (
CodeDeployDeploymentStateFailure CodeDeployDeploymentState = "FAILURE"
CodeDeployDeploymentStateReady = "READY"
CodeDeployDeploymentStateStart = "START"
CodeDeployDeploymentStateStop = "STOP"
CodeDeployDeploymentStateSuccess = "SUCCESS"
CodeDeployDeploymentStateReady CodeDeployDeploymentState = "READY"
CodeDeployDeploymentStateStart CodeDeployDeploymentState = "START"
CodeDeployDeploymentStateStop CodeDeployDeploymentState = "STOP"
CodeDeployDeploymentStateSuccess CodeDeployDeploymentState = "SUCCESS"
)

// CodeDeployEvent is documented at:
Expand Down