-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Support multiple linting rules #9859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: upgrade-linting-tool
Are you sure you want to change the base?
Support multiple linting rules #9859
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## upgrade-linting-tool #9859 +/- ##
=======================================================
Coverage ? 93.33%
=======================================================
Files ? 209
Lines ? 16807
Branches ? 0
=======================================================
Hits ? 15687
Misses ? 1120
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Just a note, the pagination linting rule should actually be based around the |
| choice = input(prompt).lower().strip() | ||
| if choice in ["y", "n", "u", "s"]: | ||
| choice = ( | ||
| input("\nApply this fix? [y]es, [n]o, [u]pdate all, [s]ave and exit, [q]uit: ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For accessibility, we should make the letter to select separate from the word that describes. A screen reader would not be able to read this well. How about:
| input("\nApply this fix? [y]es, [n]o, [u]pdate all, [s]ave and exit, [q]uit: ") | |
| input("\nApply this fix? [y] yes, [n] no, [u] update all, [s] save and exit, [q] quit: ") |
Description of changes:
'refreshed'. We avoid this problem by linting the script one-rule-at-a-time.
Base64BinaryFormatRuleso that it does not requirefile://prefix in an argument value to trigger a detection. It now flags all AWS CLI commands.PaginationRulethat flags all AWS CLI commands, and adds--no-cli-paginateas a fix.ScriptLinterclass with utility functions. Updated their interface to let callers pass in their own AST.PaginationRule.Description of tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.