Skip to content

Commit 8eb168d

Browse files
committed
Made updates according to feedback.
1 parent eb382cf commit 8eb168d

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"type": "feature",
33
"category": "s3",
4-
"description": "Adds support for checksums other than MD5 to high-level S3 commands."
4+
"description": "Adds ``--checksum-mode`` and ``--checksum-algorithm`` parameters to high-level ``s3`` commands."
55
}

awscli/customizations/s3/subcommands.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1390,7 +1390,7 @@ def _raise_if_paths_type_incorrect_for_param(self, param, paths_type, allowed_pa
13901390
}
13911391
raise ParamValidationError(
13921392
f"Expected {param} parameter to be used with one of following path formats: "
1393-
f"{', '.join(allowed_paths)} but received {expected_usage_map[paths_type]}"
1393+
f"{', '.join([expected_usage_map[path] for path in allowed_paths])}. Instead, received {expected_usage_map[paths_type]}."
13941394
)
13951395

13961396
def _normalize_s3_trailing_slash(self, paths):

tests/unit/customizations/s3/test_subcommands.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -412,29 +412,33 @@ def test_validate_checksum_algorithm_sync_download_error(self):
412412
paths = ['s3://bucket/key', self.file_creator.rootdir]
413413
parameters = {'checksum_algorithm': 'CRC32C'}
414414
cmd_params = CommandParameters('sync', parameters, '')
415-
with self.assertRaises(ParamValidationError):
415+
with self.assertRaises(ParamValidationError) as cm:
416416
cmd_params.add_paths(paths)
417+
self.assertIn('Expected checksum-algorithm parameter to be used with one of following path formats', cm.msg)
417418

418419
def test_validate_checksum_mode_upload_error(self):
419420
paths = [self.file_creator.rootdir, 's3://bucket/key']
420421
parameters = {'checksum_mode': 'ENABLED'}
421422
cmd_params = CommandParameters('cp', parameters, '')
422-
with self.assertRaises(ParamValidationError):
423+
with self.assertRaises(ParamValidationError) as cm:
423424
cmd_params.add_paths(paths)
425+
self.assertIn('Expected checksum-mode parameter to be used with one of following path formats', cm.msg)
424426

425427
def test_validate_checksum_mode_sync_upload_error(self):
426428
paths = [self.file_creator.rootdir, 's3://bucket/key']
427429
parameters = {'checksum_mode': 'ENABLED'}
428430
cmd_params = CommandParameters('sync', parameters, '')
429-
with self.assertRaises(ParamValidationError):
431+
with self.assertRaises(ParamValidationError) as cm:
430432
cmd_params.add_paths(paths)
433+
self.assertIn('Expected checksum-mode parameter to be used with one of following path formats', cm.msg)
431434

432435
def test_validate_checksum_mode_move_error(self):
433436
paths = ['s3://bucket/key', 's3://bucket2/key']
434437
parameters = {'checksum_mode': 'ENABLED'}
435438
cmd_params = CommandParameters('mv', parameters, '')
436-
with self.assertRaises(ParamValidationError):
439+
with self.assertRaises(ParamValidationError) as cm:
437440
cmd_params.add_paths(paths)
441+
self.assertIn('Expected checksum-mode parameter to be used with one of following path formats', cm.msg)
438442

439443
def test_validate_streaming_paths_error(self):
440444
parameters = {'src': '-', 'dest': 's3://bucket'}

0 commit comments

Comments
 (0)