refactor readme #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade ts-node and typescript version use default synthesizer for custom qualifer Signed-off-by: Cizer Pereira <[email protected]>
kzarms
previously requested changes
Jun 6, 2022
Contributor
kzarms
left a comment
kzarms
left a comment
There was a problem hiding this comment.
Let's discuss the purpose of the Default naming changes and fix linting errors.
The rest if fine. Thank you.
kzarms
dismissed
their stale review
Remove my blocker to unblock you. Verify with the team and make a desicion based on your judgment
added 2 commits
June 13, 2022 10:10
…nto feat/refactor-readme
C123R
force-pushed
the
feat/refactor-readme
branch
from
7d83bdd to
ca0c677
Compare
C123R
force-pushed
the
feat/refactor-readme
branch
from
ca0c677 to
0efda29
Compare
kzarms
approved these changes
Jun 20, 2022
Contributor
kzarms
left a comment
kzarms
left a comment
There was a problem hiding this comment.
Looks great for me!
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
hnb659fds.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.