Skip to content

Bug: Docs doesn't upload versions.json when being updated #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sthulb opened this issue Jun 20, 2023 · 3 comments · Fixed by #2505
Closed

Bug: Docs doesn't upload versions.json when being updated #2504

sthulb opened this issue Jun 20, 2023 · 3 comments · Fixed by #2505
Labels
bug Something isn't working

Comments

@sthulb
Copy link
Contributor

sthulb commented Jun 20, 2023

Expected Behaviour

When generating the docs and uploading to S3, the versions.json file should be updated

Current Behaviour

The action responsible for docs, doesn't generate the versions.json file

Code snippet

N/A

Possible Solution

No response

Steps to Reproduce

On release, observe the lack of versions.json file being upload

Powertools for AWS Lambda (Python) version

latest

AWS Lambda function runtime

3.10

Packaging format used

PyPi

Debugging logs

No response
@sthulb sthulb added bug Something isn't working triage Pending triage from maintainers labels Jun 20, 2023
@sthulb sthulb mentioned this issue Jun 20, 2023
Merged
7 tasks
@leandrodamascena leandrodamascena linked a pull request Jun 20, 2023 that will close this issue
fix(docs): ensure versions.json is updated #2505
Merged
7 tasks
@leandrodamascena
Copy link
Contributor

leandrodamascena commented Jun 20, 2023 •
edited
Loading

Thanks for opening this issue @sthulb! Waiting to Convert PR to Ready to Review to verify it.

@leandrodamascena leandrodamascena removed the triage Pending triage from maintainers label Jun 21, 2023
@leandrodamascena leandrodamascena moved this from Triage to Pending review in Powertools for AWS Lambda (Python) Jun 21, 2023
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (Python) Jun 23, 2023
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jun 23, 2023
@github-actions
Copy link
Contributor

This is now released under 2.18.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Jun 23, 2023
@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(docs): ensure versions.json is updated aws-powertools/powertools-lambda-python
2 participants
@sthulb @leandrodamascena