Skip to content

Commit cf39c60

Browse files
author
Michal Ploski
committed
Merge branch 'feature/e2e-tests' of github.com:mploski/aws-lambda-powertools-python into feature/e2e-tests
2 parents a2c9e34 + 936839e commit cf39c60

File tree

3 files changed

+23
-7
lines changed

3 files changed

+23
-7
lines changed

.vscode/launch.json

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"configurations": [
3+
{
4+
"name": "Python: Current File",
5+
"type": "python",
6+
"request": "launch",
7+
"program": "${file}",
8+
"console": "integratedTerminal",
9+
"justMyCode": true,
10+
"env": {
11+
"AWS_PROFILE": "aws-mploski-root"
12+
}
13+
}
14+
]
15+
}

MAINTAINERS.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,12 +166,13 @@ When necessary, be upfront that the time to review, approve, and implement a RFC
166166

167167
Some examples using our initial and new RFC templates: #92, #94, #95, #991, #1226
168168

169-
### Run end to end tests on merges to Develop branch
169+
### Run end to end tests
170170

171171
In order to run end to end tests you need to install CDK CLI first and bootstrap your account with `cdk bootstrap` command. For additional details follow [documentation](https://docs.aws.amazon.com/cdk/v2/guide/bootstrapping.html).
172172

173-
You can run tests either from your local machine's shell by exporting `AWS_PROFILE` environment variable and running `make e2e tests`.
174-
You may also do this directly from GitHub Console. Run the [run-e2e-tests workflow](https://github.com/awslabs/aws-lambda-powertools-python/actions/workflows/run-e2e-tests.yml) and pick the branch you want to run tests against.
173+
To run locally, export `AWS_PROFILE` environment variable and run `make e2e tests`. To run from GitHub Actions, use [run-e2e-tests workflow](https://github.com/awslabs/aws-lambda-powertools-python/actions/workflows/run-e2e-tests.yml) and pick the branch you want to run tests against.
174+
175+
**NOTE**: E2E tests are run as part of each merge to `develop` branch.
175176

176177
> **Q: What if there's an error?**
177178
To be agreed
@@ -182,7 +183,7 @@ To be agreed
182183
183184
Firstly, make sure you are using the `develop` branch and it is up to date with the origin.
184185

185-
There are four main steps to release a new version: Changelog generation, version bumping, and drafting release notes.
186+
There are three main steps to release a new version: Changelog generation, version bumping, and drafting release notes.
186187

187188
#### Changelog generation
188189

tests/e2e/utils/infrastructure.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class PythonVersion(Enum):
2222
V39 = {"runtime": Runtime.PYTHON_3_9, "image": Runtime.PYTHON_3_9.bundling_image.image}
2323

2424

25-
class InfrastructureStackInterface(ABC):
25+
class BaseInfrastructureStack(ABC):
2626
@abstractmethod
2727
def synthesize() -> Tuple[dict, str]:
2828
...
@@ -32,7 +32,7 @@ def __call__() -> Tuple[dict, str]:
3232
...
3333

3434

35-
class InfrastructureStack(InfrastructureStackInterface):
35+
class InfrastructureStack(BaseInfrastructureStack):
3636
def __init__(self, handlers_dir: str, stack_name: str, config: dict) -> None:
3737
self.stack_name = stack_name
3838
self.handlers_dir = handlers_dir
@@ -123,7 +123,7 @@ def __init__(self, stack_name: str, handlers_dir: str, config: dict) -> None:
123123
self.handlers_dir = handlers_dir
124124
self.config = config
125125

126-
def deploy(self, Stack: Type[InfrastructureStackInterface]) -> Dict[str, str]:
126+
def deploy(self, Stack: Type[BaseInfrastructureStack]) -> Dict[str, str]:
127127

128128
stack = Stack(handlers_dir=self.handlers_dir, stack_name=self.stack_name, config=self.config)
129129
template, asset_root_dir, asset_manifest_file = stack()

0 commit comments

Comments
 (0)