Skip to content

Commit 7a8b5e1

Browse files
committed
chore: fix new feedback set
1 parent 70516ca commit 7a8b5e1

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

tests/e2e/conftest.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55

66
import boto3
77

8-
# We only need typing_extensions for python versions <3.8
9-
from tests.e2e.utils import data_fetcher
8+
from tests.e2e.utils import data_fetcher, infrastructure
109

10+
# We only need typing_extensions for python versions <3.8
1111
if sys.version_info >= (3, 8):
1212
from typing import TypedDict
1313
else:
@@ -16,7 +16,6 @@
1616
from typing import Dict, Generator, Optional
1717

1818
import pytest
19-
from e2e.utils import infrastructure
2019

2120

2221
class LambdaConfig(TypedDict):

tests/e2e/utils/asset.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
logger = Logger(service="e2e-utils")
1515

1616

17-
class AssetTemplateConfigSource(BaseModel):
17+
class AssetManifest(BaseModel):
1818
path: str
1919
packaging: str
2020

@@ -32,14 +32,13 @@ class AssetTemplateConfigDestinations(BaseModel):
3232

3333

3434
class AssetTemplateConfig(BaseModel):
35-
source: AssetTemplateConfigSource
35+
source: AssetManifest
3636
destinations: AssetTemplateConfigDestinations
3737

3838

3939
class TemplateAssembly(BaseModel):
4040
version: str
4141
files: Dict[str, AssetTemplateConfig]
42-
docker_images: Dict = Field(Dict, alias="dockerImages")
4342

4443

4544
class Asset:

tests/e2e/utils/data_fetcher/metrics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def get_metrics(
2222
) -> MetricDataResultTypeDef:
2323
"""Fetch CloudWatch Metrics
2424
25-
It takes into account eventual consistency with up to 10 retries and 1s jitter.
25+
It takes into account eventual consistency with up to 10 retries and 1.5s jitter.
2626
2727
Parameters
2828
----------

tests/e2e/utils/data_fetcher/traces.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ def __init__(
8282
self.start_date = start_date
8383
self.end_date = end_date or self.start_date + timedelta(minutes=5)
8484
self.xray_client: XRayClient = xray_client or boto3.client("xray")
85-
self.trace_ids: List[str] = []
8685
self.trace_documents: Dict[str, TraceDocument] = {}
8786
self.subsegments: List[TraceSubsegment] = []
8887
self.exclude_segment_name = exclude_segment_name or self.default_exclude_seg_name
@@ -101,8 +100,8 @@ def __init__(
101100
FilterExpression=self.filter_expression,
102101
)
103102

104-
self.trace_ids = self._get_trace_ids(pages)
105-
self.trace_documents = self._get_trace_documents()
103+
trace_ids = self._get_trace_ids(pages)
104+
self.trace_documents = self._get_trace_documents(trace_ids)
106105
self.subsegments = self._get_subsegments()
107106

108107
def get_annotation(self, key: str, value: Optional[any] = None) -> List:
@@ -198,7 +197,7 @@ def _get_trace_ids(self, pages: PageIterator) -> List[str]:
198197

199198
return trace_ids
200199

201-
def _get_trace_documents(self) -> Dict[str, TraceDocument]:
200+
def _get_trace_documents(self, trace_ids: List[str]) -> Dict[str, TraceDocument]:
202201
"""Find trace documents available in each trace segment
203202
204203
Returns

0 commit comments

Comments
 (0)