Skip to content

Commit 5626c97

Browse files
chore(ci): add the Metrics feature to nox tests (#4552)
1 parent c509412 commit 5626c97

13 files changed

+18
-3
lines changed

noxfile.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,25 @@ def build_and_run_test(session: nox.Session, folders: List, extras: Optional[str
5050
def test_with_only_required_packages(session: nox.Session):
5151
"""Tests that only depends for required libraries"""
5252
# Logger
53+
# Metrics - Amazon CloudWatch EMF
54+
# Metrics - Base provider
5355
build_and_run_test(
5456
session,
5557
folders=[
56-
f"{PREFIX_TESTS_FUNCTIONAL}/logger/",
58+
f"{PREFIX_TESTS_FUNCTIONAL}/logger/required_dependencies/",
59+
f"{PREFIX_TESTS_FUNCTIONAL}/metrics/required_dependencies/",
5760
],
5861
)
62+
63+
64+
@nox.session()
65+
def test_with_datadog_as_required_package(session: nox.Session):
66+
"""Tests that depends on Datadog library"""
67+
# Metrics - Datadog
68+
build_and_run_test(
69+
session,
70+
folders=[
71+
f"{PREFIX_TESTS_FUNCTIONAL}/metrics/datadog/",
72+
],
73+
extras="datadog",
74+
)

tests/functional/logger/__init__.py

Whitespace-only changes.

tests/functional/logger/required_dependencies/__init__.py

Whitespace-only changes.

tests/functional/metrics/__init__.py

Whitespace-only changes.

tests/functional/metrics/datadog/__init__.py

Whitespace-only changes.

tests/functional/metrics/test_metrics_datadog.py renamed to tests/functional/metrics/datadog/test_metrics_datadog.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
from collections import namedtuple
44

55
import pytest
6-
from test_metrics_provider import capture_metrics_output
76

87
from aws_lambda_powertools.metrics.exceptions import MetricValueError, SchemaValidationError
98
from aws_lambda_powertools.metrics.provider.cold_start import reset_cold_start_flag
@@ -40,7 +39,7 @@ def test_datadog_write_to_log_with_env_variable(capsys, monkeypatch):
4039
# WHEN we add a metric
4140
metrics.add_metric(name="item_sold", value=1, product="latte", order="online")
4241
metrics.flush_metrics()
43-
logs = capture_metrics_output(capsys)
42+
logs = json.loads(capsys.readouterr().out.strip())
4443

4544
# THEN metrics is flushed to log
4645
logs["e"] = ""

tests/functional/metrics/required_dependencies/__init__.py

Whitespace-only changes.

0 commit comments

Comments
 (0)