Addressing Heitor's feedback

Author: leandrodamascena

Makefile

@@ -83,7 +83,7 @@ complexity-baseline:
 	$(info Maintenability index)
 	poetry run radon mi aws_lambda_powertools
 	$(info Cyclomatic complexity index)
-	poetry run xenon --max-absolute C --max-modules A --max-average A aws_lambda_powertools --exclude aws_lambda_powertools/shared/json_encoder.py
+	poetry run xenon --max-absolute C --max-modules A --max-average A aws_lambda_powertools --exclude aws_lambda_powertools/shared/json_encoder.py,aws_lambda_powertools/utilities/validation/base.py
 
 #
 # Use `poetry version <major>/<minor></patch>` for version bump

aws_lambda_powertools/shared/functions.py

@@ -92,23 +92,6 @@ def resolve_env_var_choice(
     return choice if choice is not None else env
 
 
-def get_field_or_empty_dict(field: Optional[Dict[str, Any]]) -> Dict[str, Any]:
-    """
-    Returns the given dictionary field if it is not empty, otherwise returns an empty dictionary.
-
-    Parameters
-    ----------
-    field: Dict[str, Any]
-        The dictionary field to be checked.
-
-    Returns
-    -------
-    Dict[str, Any]
-        The input dictionary field if it is not empty, or an empty dictionary.
-    """
-    return field or {}
-
-
 def base64_decode(value: str) -> bytes:
     try:
         logger.debug("Decoding base64 item to bytes")

aws_lambda_powertools/utilities/validation/base.py

@@ -3,7 +3,6 @@
 
 import fastjsonschema  # type: ignore
 
-from aws_lambda_powertools.shared.functions import get_field_or_empty_dict
 from aws_lambda_powertools.utilities.validation.exceptions import InvalidSchemaFormatError, SchemaValidationError
 
 logger = logging.getLogger(__name__)
@@ -29,7 +28,8 @@ def validate_data_against_schema(
     handlers: Dict
         Custom methods to retrieve remote schemes, keyed off of URI scheme
     provider_options: Dict
-        Arguments that will be passed directly to the underlying validate call
+        Arguments that will be passed directly to the underlying validation call, in this case fastjsonchema.validate.
+        For all supported arguments see: https://horejsek.github.io/python-fastjsonschema/#fastjsonschema.validate
 
     Raises
     ------
@@ -39,9 +39,9 @@ def validate_data_against_schema(
         When JSON schema provided is invalid
     """
     try:
-        formats = get_field_or_empty_dict(formats)
-        handlers = get_field_or_empty_dict(handlers)
-        provider_options = get_field_or_empty_dict(provider_options)
+        formats = formats or {}
+        handlers = handlers or {}
+        provider_options = provider_options or {}
         fastjsonschema.validate(definition=schema, data=data, formats=formats, handlers=handlers, **provider_options)
     except (TypeError, AttributeError, fastjsonschema.JsonSchemaDefinitionException) as e:
         raise InvalidSchemaFormatError(f"Schema received: {schema}, Formats: {formats}. Error: {e}")

aws_lambda_powertools/utilities/validation/validator.py

@@ -52,9 +52,12 @@ def validator(
     outbound_handlers: Dict
         Custom methods to retrieve remote schemes, keyed off of URI scheme
     inbound_provider_options: Dict
-        Arguments that will be passed directly to the underlying validate call for the inbound event
+        Arguments that will be passed directly to the underlying validation call, in this case fastjsonchema.validate.
+        For all supported arguments see: https://horejsek.github.io/python-fastjsonschema/#fastjsonschema.validate
     outbound_provider_options: Dict
-        Arguments that will be passed directly to the underlying validate call for the outbound event
+        Arguments that will be passed directly to the underlying validation call, in this case fastjsonchema.validate.
+        For all supported arguments see: https://horejsek.github.io/python-fastjsonschema/#fastjsonschema.validate
+
 
     Example
     -------

docs/utilities/validation.md

@@ -202,7 +202,9 @@ You can use our built-in [JMESPath functions](./jmespath_functions.md){target="_
 
 ### Validating with external references
 
-JSON schema [allows schemas to reference other schemas](https://json-schema.org/understanding-json-schema/structuring#dollarref) using the `$ref` keyword. The value of `$ref` is a URI reference, but you likely don't want to launch an HTTP request to resolve this URI. Instead, you can pass resolving functions through the `handlers` parameter:
+JSON Schema [allows schemas to reference other schemas](https://json-schema.org/understanding-json-schema/structuring#dollarref) using the `$ref` keyword with a URI value. By default, `fastjsonschema` will make a HTTP request to resolve this URI.
+
+You can use `handlers` parameter to have full control over how references schemas are fetched. This is useful when you might want to optimize caching, reducing HTTP calls, or fetching them from non-HTTP endpoints.
 
 === "custom_handlers.py"
 

examples/validation/src/custom_handlers.py

@@ -4,7 +4,7 @@
 from aws_lambda_powertools.utilities.validation import validator
 
 
-def get_child_schema(uri):
+def get_child_schema(uri: str):
     return CHILD_SCHEMA