From ab0406db3d77cb72d344766ee993c518ffc6ba1a Mon Sep 17 00:00:00 2001 From: Pankaj Agrawal Date: Mon, 4 Oct 2021 10:33:48 +0200 Subject: [PATCH 1/2] chore: spotbug check --- .../lambda/powertools/sqs/SQSBatchProcessingException.java | 1 + 1 file changed, 1 insertion(+) diff --git a/powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SQSBatchProcessingException.java b/powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SQSBatchProcessingException.java index 85231a003..a887f73e1 100644 --- a/powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SQSBatchProcessingException.java +++ b/powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SQSBatchProcessingException.java @@ -33,6 +33,7 @@ public class SQSBatchProcessingException extends RuntimeException { private final List failures; private final List returnValues; + public SQSBatchProcessingException(final List exceptions, final List failures, final List successReturns) { From fd7fa49f44bfea1add373cf8b461e1df45ba97ff Mon Sep 17 00:00:00 2001 From: Pankaj Agrawal Date: Mon, 4 Oct 2021 11:00:07 +0200 Subject: [PATCH 2/2] chore: spotsbug check fix for remote forks pr --- .github/workflows/spotbugs.yml | 15 +++++++++------ .../sqs/SQSBatchProcessingException.java | 1 - 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/spotbugs.yml b/.github/workflows/spotbugs.yml index da0939fbb..ff1a28c4d 100644 --- a/.github/workflows/spotbugs.yml +++ b/.github/workflows/spotbugs.yml @@ -24,11 +24,14 @@ jobs: with: distribution: 'zulu' java-version: 8 - - name: Build with Maven for spotbugs check to gather reports - run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=false - - uses: jwgmeligmeyling/spotbugs-github-action@master - with: - path: '**/spotbugsXml.xml' - # Can be simplified post this issue is fixed https://github.com/jwgmeligmeyling/spotbugs-github-action/issues/9 + # https://github.com/jwgmeligmeyling/spotbugs-github-action/issues/6 + # https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/ + # Avoid complexity of git action with publishing report. Just build with spotbugs profile. +# - name: Build with Maven for spotbugs check to gather reports +# run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=false +# - uses: jwgmeligmeyling/spotbugs-github-action@master +# with: +# path: '**/spotbugsXml.xml' +# # Can be simplified post this issue is fixed https://github.com/jwgmeligmeyling/spotbugs-github-action/issues/9 - name: Build with Maven for spotbugs check to mark build as fail if voilations found run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=true \ No newline at end of file diff --git a/powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SQSBatchProcessingException.java b/powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SQSBatchProcessingException.java index a887f73e1..85231a003 100644 --- a/powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SQSBatchProcessingException.java +++ b/powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SQSBatchProcessingException.java @@ -33,7 +33,6 @@ public class SQSBatchProcessingException extends RuntimeException { private final List failures; private final List returnValues; - public SQSBatchProcessingException(final List exceptions, final List failures, final List successReturns) {