Apply suggestions from code review

Co-authored-by: Scott Gerring <[email protected]>

Author: jeromevdl

powertools-large-messages/pom.xml

@@ -129,7 +129,7 @@
         <plugins>
             <plugin>
                 <artifactId>maven-surefire-plugin</artifactId>
-                <version>3.1.2</version>
+                <version>${maven-surefire-plugin.version}</version>
                 <configuration>
                     <environmentVariables>
                         <AWS_REGION>eu-central-1</AWS_REGION>

powertools-large-messages/src/main/java/software/amazon/lambda/powertools/largemessages/LargeMessage.java

@@ -50,6 +50,7 @@
 
     /**
      * Specify if S3 objects must be deleted after being processed (default = true)
+     Alternatively you might consider using S3 lifecycle policies to remove the payloads automatically after a period of time.
      */
     boolean deleteS3Object() default true;
 }

powertools-large-messages/src/main/java/software/amazon/lambda/powertools/largemessages/LargeMessageConfig.java

@@ -8,7 +8,7 @@
 import static software.amazon.lambda.powertools.core.internal.LambdaConstants.AWS_REGION_ENV;
 
 /**
- * Singleton instance for Large Message Config.
+ * Singleton instance for Large Message Config. We need this to provide a way to customize the S3 client configuration used by the annotation.
  * <br/>
  * Optional: Use it in your Lambda constructor to pass a custom {@link S3Client} to the {@link software.amazon.lambda.powertools.largemessages.internal.LargeMessageProcessor}
  * <br/>

powertools-large-messages/src/main/java/software/amazon/lambda/powertools/largemessages/internal/LargeMessageProcessorFactory.java

@@ -5,7 +5,7 @@
 
 import java.util.Optional;
 
-public class LargeMessageProcessorFactory {
+class LargeMessageProcessorFactory {
 
     private LargeMessageProcessorFactory() {
         // not intended to be instantiated

powertools-large-messages/src/main/java/software/amazon/lambda/powertools/largemessages/internal/LargeSNSMessageProcessor.java

@@ -6,7 +6,7 @@
 import java.util.HashMap;
 import java.util.Map;
 
-public class LargeSNSMessageProcessor extends LargeMessageProcessor<SNSRecord> {
+class LargeSNSMessageProcessor extends LargeMessageProcessor<SNSRecord> {
 
     @Override
     protected String getMessageId(SNSRecord message) {

powertools-large-messages/src/main/java/software/amazon/lambda/powertools/largemessages/internal/LargeSQSMessageProcessor.java

@@ -17,7 +17,7 @@
 import java.util.Map;
 import java.util.Optional;
 
-public class LargeSQSMessageProcessor extends LargeMessageProcessor<SQSMessage> {
+class LargeSQSMessageProcessor extends LargeMessageProcessor<SQSMessage> {
 
     private static final Logger LOG = LoggerFactory.getLogger(LargeSQSMessageProcessor.class);
     private static final String LEGACY_RESERVED_ATTRIBUTE_NAME = "SQSLargePayloadSize";