sonar lint

jeromevdl · jeromevdl · commit 7b84d4c5f4ae · 2023-09-22T13:15:27.000+02:00
diff --git a/powertools-logging/powertools-logging-logback/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaEcsSerializer.java b/powertools-logging/powertools-logging-logback/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaEcsSerializer.java
@@ -59,6 +59,8 @@ public class LambdaEcsSerializer {
     protected static final String FUNCTION_MEMORY_ATTR_NAME = "faas.memory";
     protected static final String FUNCTION_TRACE_ID_ATTR_NAME = "trace.id";
 
+    private LambdaEcsSerializer() {}
+
     public static void serializeObjectStart(StringBuilder builder) {
         builder.append('{');
     }
@@ -97,7 +99,7 @@ public static void serializeLogLevel(StringBuilder builder, Level level) {
 
     public static void serializeFormattedMessage(StringBuilder builder, String formattedMessage) {
         serializeAttributeAsString(builder, FORMATTED_MESSAGE_ATTR_NAME,
-                formattedMessage.replaceAll("\"", Matcher.quoteReplacement("\\\"")));
+                formattedMessage.replace("\"", Matcher.quoteReplacement("\\\"")));
     }
 
     public static void serializeException(StringBuilder builder, String className, String message, String stackTrace) {
diff --git a/powertools-logging/powertools-logging-logback/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaJsonSerializer.java b/powertools-logging/powertools-logging-logback/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaJsonSerializer.java
@@ -44,6 +44,7 @@ public class LambdaJsonSerializer {
     protected static final String EXCEPTION_STACK_ATTR_NAME = "stack";
     protected static final String EXCEPTION_ATTR_NAME = "error";
 
+    private LambdaJsonSerializer() {}
 
     public static void serializeObjectStart(StringBuilder builder) {
         builder.append('{');
@@ -83,7 +84,7 @@ public static void serializeLogLevel(StringBuilder builder, Level level) {
 
     public static void serializeFormattedMessage(StringBuilder builder, String formattedMessage) {
         serializeAttribute(builder, FORMATTED_MESSAGE_ATTR_NAME,
-                formattedMessage.replaceAll("\"", Matcher.quoteReplacement("\\\"")));
+                formattedMessage.replace("\"", Matcher.quoteReplacement("\\\"")));
     }
 
     public static void serializeException(StringBuilder builder, String className, String message, String stackTrace) {

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,8 @@ public class LambdaEcsSerializer {`
`59`	`59`	`protected static final String FUNCTION_MEMORY_ATTR_NAME = "faas.memory";`
`60`	`60`	`protected static final String FUNCTION_TRACE_ID_ATTR_NAME = "trace.id";`
`61`	`61`
	`62`	`+ private LambdaEcsSerializer() {}`
	`63`	`+`
`62`	`64`	`public static void serializeObjectStart(StringBuilder builder) {`
`63`	`65`	`builder.append('{');`
`64`	`66`	`}`
`@@ -97,7 +99,7 @@ public static void serializeLogLevel(StringBuilder builder, Level level) {`
`97`	`99`
`98`	`100`	`public static void serializeFormattedMessage(StringBuilder builder, String formattedMessage) {`
`99`	`101`	`serializeAttributeAsString(builder, FORMATTED_MESSAGE_ATTR_NAME,`
`100`		`- formattedMessage.replaceAll("\"", Matcher.quoteReplacement("\\\"")));`
	`102`	`+ formattedMessage.replace("\"", Matcher.quoteReplacement("\\\"")));`
`101`	`103`	`}`
`102`	`104`
`103`	`105`	`public static void serializeException(StringBuilder builder, String className, String message, String stackTrace) {`