-
Notifications
You must be signed in to change notification settings - Fork 26
Feature request: Reduce use of lesser known packages in Idemopotency package #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening your first issue here! We'll come back to you as soon as we can. |
@mungojam Thanks for raising this feature request. We are discussing what you wrote between the team and will get back to you soon. |
@mungojam Release 1.10.0 removes dependency on 3rd party JMESPath. Using Idempotency 1.2.1 will not have that external dependency. |
@hjgraca nice one, thanks for the change. We'll look to adopt it now as nothing blocking anymore |
Use case
We have to be careful with the dependencies that we bring in. The Idempotency package brings in a JmesPath package which then brings in other sub-packages. The sub-packages are particularly obscure, developed as a university project with very few users. https://www.nuget.org/packages/Springcomp.GPPG.Runtime
We would like the JmesPath package dependency to be replaced with native System.Text.Json functionality, or else a more widely used package (e.g. Newtonsoft.Json).
Otherwise I don't think we will be able to make use of the Idempotency package.
Solution/User Experience
It seems that the main use is here, and could be replaced with a System.Text.Json use:
https://github.com/aws-powertools/powertools-lambda-dotnet/blob/develop/libraries/src/AWS.Lambda.Powertools.Idempotency/Serialization/JsonFunction.cs
Alternative solutions
No response
Acknowledgment
The text was updated successfully, but these errors were encountered: