Feature request: Add DateOnly Converter to Logging JsonSerializer

[BradKnowles]

Use case

If the object being logged has a DateOnly property the Logging framework throws an exception.

Serialization and deserialization of 'System.DateOnly' instances are not supported. The unsupported member type is located on type 'System.Nullable``1[System.DateOnly]'

Solution/User Experience

Ideally, the Logging framework would handle DateOnly fields without any additional or custom logic from application developers.

Alternative solutions

At the moment, the workaround is to add a [JsonConverter(typeof(DateOnlyJsonConverter))] attribute to each property of the object being serialized, where DateOnlyConverter is a custom converter that is each of our applications.

Acknowledgment

• This feature request meets Powertools for AWS Lambda (.NET) Tenets
• Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and TypeScript

[boring-cyborg]

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #dotnet channel on our Powertools for AWS Lambda Discord: Invite link

[hjgraca]

Hi @BradKnowles , this is a .Net 6 limitation System.Text.Json source generator does not have built-in support for DateOnly/TimeOnly types, this was added to .NET 7. https://devblogs.microsoft.com/dotnet/system-text-json-in-dotnet-7/#source-generation-improvements and dotnet/runtime#53539.

This is an issue that will be present in other utilities like Tracing, due to the way XRay SDK does serialization. aws/aws-xray-sdk-dotnet#212

We will discuss this internally to see if there is anything we can do to improve the experience. At the moment the solution is to create the converters.

[hjgraca]

cc: @amirkaws

[BradKnowles]

I was thinking it could be added like the ByteArrayConverter etc. was added in PR #152.

[hjgraca]

@BradKnowles we will be adding custom converter for DateOnly and TmeOnly. Thanks for raising the issue. We will be updating this issue with the progress.

[hjgraca]

@BradKnowles released in version 1.8.1 - Logging version 1.3.3.
Really appreciate opening this issue and the feedback.