Skip to content

Docs: Improve Logger Extra Keys samples #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
sliedig opened this issue Oct 11, 2022 · 1 comment
Closed
1 task done

Docs: Improve Logger Extra Keys samples #166

sliedig opened this issue Oct 11, 2022 · 1 comment
Assignees
@hjgraca
Labels
area/logging Core logging utility documentation Improvements or additions to documentation released Fix or implementation already in main and released
Milestone
Logging V2

Comments

@sliedig
Copy link
Contributor

sliedig commented Oct 11, 2022

What were you searching in the docs?

ATM the extra keys samples do not show correct implementation. Shows Logger.AppendKeys method not Logger.AppendKey.

Is this related to an existing documentation section?

https://awslabs.github.io/aws-lambda-powertools-dotnet/core/logging/#extra-keys

How can we improve?

Add `Logger.AppendKey` sample
Add `Logger.LogInformation(extra keys...)` sample
Add anonymous type to log entire object payload

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@sliedig sliedig added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Oct 11, 2022
@sliedig sliedig self-assigned this Jan 31, 2023
@sliedig sliedig removed the triage Pending triage from maintainers label Jan 31, 2023
@hjgraca hjgraca moved this to 📋 Backlog in AWS Lambda Powertools for .NET Mar 2, 2023
@amirkaws amirkaws mentioned this issue Apr 13, 2023
Closed
@sliedig sliedig assigned amirkaws and unassigned sliedig Apr 14, 2023
@amirkaws amirkaws mentioned this issue Apr 14, 2023
Closed
7 tasks
@sthulb sthulb moved this to 📋 Backlog in Powertools for AWS Lambda (.NET) Jun 19, 2023
@hjgraca hjgraca added the area/logging Core logging utility label Dec 12, 2023
@hjgraca hjgraca added this to the Logging V2 milestone Dec 12, 2023
@heitorlessa heitorlessa mentioned this issue May 6, 2024
Closed
@hjgraca hjgraca self-assigned this Mar 24, 2025
@hjgraca hjgraca moved this from 📋 Backlog to ✅ Done in Powertools for AWS Lambda (.NET) Apr 8, 2025
@hjgraca
Copy link
Contributor

hjgraca commented Apr 8, 2025

This is now fixed in the current documenation

@hjgraca hjgraca closed this as completed Apr 8, 2025
@hjgraca hjgraca added the released Fix or implementation already in main and released label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjgraca hjgraca

Labels
area/logging Core logging utility documentation Improvements or additions to documentation released Fix or implementation already in main and released
Projects
Powertools for AWS Lambda (.NET)
Status: ✅ Done
Milestone
Logging V2
Development

No branches or pull requests
3 participants
@sliedig @hjgraca @amirkaws