Skip to content

Conversation

@michaelhtm
Copy link
Member

Description of changes:
The To/FromACKTags function signatures are changing with the next
code-gen release. This PR aims to ensure custom code adapts as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler March 14, 2025 03:12
@ack-prow ack-prow bot added the approved label Mar 14, 2025
The To/FromACKTags function signatures are changing with the next
code-gen release. This PR aims to ensure custom code adapts as well.
@michaelhtm michaelhtm force-pushed the update/acktagsconversion branch from bc866b1 to e122c18 Compare March 14, 2025 20:56
@ack-prow
Copy link

ack-prow bot commented Mar 14, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sqs-verify-attribution e122c18 link false /test sqs-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
@ack-prow
Copy link

ack-prow bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit c994e85 into aws-controllers-k8s:main Mar 27, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants