Skip to content

Commit 9579f32

Browse files
authored
Generate with SDK-V2 model (#67)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 350329f commit 9579f32

File tree

10 files changed

+239
-137
lines changed

10 files changed

+239
-137
lines changed

apis/v1alpha1/ack-generate-metadata.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
ack_generate_info:
2-
build_date: "2025-01-23T02:30:03Z"
3-
build_hash: 2442aa071c05fcdf54841e63abd5f91d1951e152
2+
build_date: "2025-02-05T16:47:04Z"
3+
build_hash: 3d74f13b9de7134b4c76ab7526a9c578c4857602
44
go_version: go1.23.5
5-
version: v0.41.0
6-
api_directory_checksum: 8f26009577f13f96d7f6ba08a96e95f2f7f08b86
5+
version: v0.41.0-18-g3d74f13
6+
api_directory_checksum: 4ac478341a3f0c78ced7a23fceda9f89fe25c242
77
api_version: v1alpha1
8-
aws_sdk_go_version: v1.55.5
8+
aws_sdk_go_version: v1.32.6
99
generator_config_info:
1010
file_checksum: 662a51e8e4a1225d04aa0121d55827e0a9a054af
1111
original_file_name: generator.yaml

apis/v1alpha1/enums.go

Lines changed: 19 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/controller/main.go

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go.mod

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,11 @@ toolchain go1.22.5
77
require (
88
github.com/aws-controllers-k8s/iam-controller v1.1.1
99
github.com/aws-controllers-k8s/kms-controller v1.0.2
10-
github.com/aws-controllers-k8s/runtime v0.41.0
10+
github.com/aws-controllers-k8s/runtime v0.41.1-0.20250204215244-e48dd7b2d6d0
1111
github.com/aws/aws-sdk-go v1.55.5
12+
github.com/aws/aws-sdk-go-v2 v1.34.0
13+
github.com/aws/aws-sdk-go-v2/service/sqs v1.37.10
14+
github.com/aws/smithy-go v1.22.2
1215
github.com/go-logr/logr v1.4.2
1316
github.com/spf13/pflag v1.0.5
1417
k8s.io/api v0.31.0
@@ -18,6 +21,17 @@ require (
1821
)
1922

2023
require (
24+
github.com/aws/aws-sdk-go-v2/config v1.28.6 // indirect
25+
github.com/aws/aws-sdk-go-v2/credentials v1.17.47 // indirect
26+
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.21 // indirect
27+
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.29 // indirect
28+
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.29 // indirect
29+
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 // indirect
30+
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.12.1 // indirect
31+
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.12.6 // indirect
32+
github.com/aws/aws-sdk-go-v2/service/sso v1.24.7 // indirect
33+
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.28.6 // indirect
34+
github.com/aws/aws-sdk-go-v2/service/sts v1.33.2 // indirect
2135
github.com/beorn7/perks v1.0.1 // indirect
2236
github.com/cenkalti/backoff/v4 v4.3.0 // indirect
2337
github.com/cespare/xxhash/v2 v2.3.0 // indirect
@@ -41,7 +55,6 @@ require (
4155
github.com/itchyny/gojq v0.12.6 // indirect
4256
github.com/itchyny/timefmt-go v0.1.3 // indirect
4357
github.com/jaypipes/envutil v1.0.0 // indirect
44-
github.com/jmespath/go-jmespath v0.4.0 // indirect
4558
github.com/josharian/intern v1.0.0 // indirect
4659
github.com/json-iterator/go v1.1.12 // indirect
4760
github.com/mailru/easyjson v0.7.7 // indirect

go.sum

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,38 @@ github.com/aws-controllers-k8s/iam-controller v1.1.1 h1:O6arh7DNlQF26MEKzgA2/kBE
22
github.com/aws-controllers-k8s/iam-controller v1.1.1/go.mod h1:2+ARwRpazTq5MErjMz0MpXHhtAzRfNtY56Uj0gvu9vE=
33
github.com/aws-controllers-k8s/kms-controller v1.0.2 h1:v8nh/oaX/U6spCwBDaWyem7XXpzoP/MnkJyEjNOZN9s=
44
github.com/aws-controllers-k8s/kms-controller v1.0.2/go.mod h1:BeoijsyGjJ9G5VcDjpFdxBW0IxaeKXYX497XmUJiPSQ=
5-
github.com/aws-controllers-k8s/runtime v0.41.0 h1:WumDnUiVlqnYYGEIGSOUBgDPWTIEozW8HT0qwGapDgA=
6-
github.com/aws-controllers-k8s/runtime v0.41.0/go.mod h1:Tuq5AFGJQcU00MY+J5hBYbLctpR50I8iGs5TPLox+u8=
5+
github.com/aws-controllers-k8s/runtime v0.41.1-0.20250204215244-e48dd7b2d6d0 h1:ygZwhPfearlE8/P0HY8rXpFsbarwJ5tzBIov+3xgQfk=
6+
github.com/aws-controllers-k8s/runtime v0.41.1-0.20250204215244-e48dd7b2d6d0/go.mod h1:Oy0JKvDxZMZ+SVupm4NZVqP00KLIIAMfk93KnOwlt5c=
77
github.com/aws/aws-sdk-go v1.55.5 h1:KKUZBfBoyqy5d3swXyiC7Q76ic40rYcbqH7qjh59kzU=
88
github.com/aws/aws-sdk-go v1.55.5/go.mod h1:eRwEWoyTWFMVYVQzKMNHWP5/RV4xIUGMQfXQHfHkpNU=
9+
github.com/aws/aws-sdk-go-v2 v1.34.0 h1:9iyL+cjifckRGEVpRKZP3eIxVlL06Qk1Tk13vreaVQU=
10+
github.com/aws/aws-sdk-go-v2 v1.34.0/go.mod h1:JgstGg0JjWU1KpVJjD5H0y0yyAIpSdKEq556EI6yOOM=
11+
github.com/aws/aws-sdk-go-v2/config v1.28.6 h1:D89IKtGrs/I3QXOLNTH93NJYtDhm8SYa9Q5CsPShmyo=
12+
github.com/aws/aws-sdk-go-v2/config v1.28.6/go.mod h1:GDzxJ5wyyFSCoLkS+UhGB0dArhb9mI+Co4dHtoTxbko=
13+
github.com/aws/aws-sdk-go-v2/credentials v1.17.47 h1:48bA+3/fCdi2yAwVt+3COvmatZ6jUDNkDTIsqDiMUdw=
14+
github.com/aws/aws-sdk-go-v2/credentials v1.17.47/go.mod h1:+KdckOejLW3Ks3b0E3b5rHsr2f9yuORBum0WPnE5o5w=
15+
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.21 h1:AmoU1pziydclFT/xRV+xXE/Vb8fttJCLRPv8oAkprc0=
16+
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.21/go.mod h1:AjUdLYe4Tgs6kpH4Bv7uMZo7pottoyHMn4eTcIcneaY=
17+
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.29 h1:Ej0Rf3GMv50Qh4G4852j2djtoDb7AzQ7MuQeFHa3D70=
18+
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.29/go.mod h1:oeNTC7PwJNoM5AznVr23wxhLnuJv0ZDe5v7w0wqIs9M=
19+
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.29 h1:6e8a71X+9GfghragVevC5bZqvATtc3mAMgxpSNbgzF0=
20+
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.29/go.mod h1:c4jkZiQ+BWpNqq7VtrxjwISrLrt/VvPq3XiopkUIolI=
21+
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 h1:VaRN3TlFdd6KxX1x3ILT5ynH6HvKgqdiXoTxAF4HQcQ=
22+
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1/go.mod h1:FbtygfRFze9usAadmnGJNc8KsP346kEe+y2/oyhGAGc=
23+
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.12.1 h1:iXtILhvDxB6kPvEXgsDhGaZCSC6LQET5ZHSdJozeI0Y=
24+
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.12.1/go.mod h1:9nu0fVANtYiAePIBh2/pFUSwtJ402hLnp854CNoDOeE=
25+
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.12.6 h1:50+XsN70RS7dwJ2CkVNXzj7U2L1HKP8nqTd3XWEXBN4=
26+
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.12.6/go.mod h1:WqgLmwY7so32kG01zD8CPTJWVWM+TzJoOVHwTg4aPug=
27+
github.com/aws/aws-sdk-go-v2/service/sqs v1.37.10 h1:j297R5mnr3LKYqr9xhsqDdFEL8OfHE0kGN1sTMFT00E=
28+
github.com/aws/aws-sdk-go-v2/service/sqs v1.37.10/go.mod h1:F6guYEP0P7+rR/2zs10iNC5JPrWPmDdTV6VIYQsHnyE=
29+
github.com/aws/aws-sdk-go-v2/service/sso v1.24.7 h1:rLnYAfXQ3YAccocshIH5mzNNwZBkBo+bP6EhIxak6Hw=
30+
github.com/aws/aws-sdk-go-v2/service/sso v1.24.7/go.mod h1:ZHtuQJ6t9A/+YDuxOLnbryAmITtr8UysSny3qcyvJTc=
31+
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.28.6 h1:JnhTZR3PiYDNKlXy50/pNeix9aGMo6lLpXwJ1mw8MD4=
32+
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.28.6/go.mod h1:URronUEGfXZN1VpdktPSD1EkAL9mfrV+2F4sjH38qOY=
33+
github.com/aws/aws-sdk-go-v2/service/sts v1.33.2 h1:s4074ZO1Hk8qv65GqNXqDjmkf4HSQqJukaLuuW0TpDA=
34+
github.com/aws/aws-sdk-go-v2/service/sts v1.33.2/go.mod h1:mVggCnIWoM09jP71Wh+ea7+5gAp53q+49wDFs1SW5z8=
35+
github.com/aws/smithy-go v1.22.2 h1:6D9hW43xKFrRx/tXXfAlIZc4JI+yQe6snnWcQyxSyLQ=
36+
github.com/aws/smithy-go v1.22.2/go.mod h1:irrKGvNn1InZwb2d7fkIRNucdfwR8R+Ts3wxYa/cJHg=
937
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
1038
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
1139
github.com/cenkalti/backoff/v4 v4.3.0 h1:MyRJ/UdXutAwSAT+s3wNd7MfTIcy71VQueUuFK343L8=
@@ -69,8 +97,6 @@ github.com/jaypipes/envutil v1.0.0 h1:u6Vwy9HwruFihoZrL0bxDLCa/YNadGVwKyPElNmZWo
6997
github.com/jaypipes/envutil v1.0.0/go.mod h1:vgIRDly+xgBq0eeZRcflOHMMobMwgC6MkMbxo/Nw65M=
7098
github.com/jmespath/go-jmespath v0.4.0 h1:BEgLn5cpjn8UN1mAw4NjwDrS35OdebyEtFe+9YPoQUg=
7199
github.com/jmespath/go-jmespath v0.4.0/go.mod h1:T8mJZnbsbmF+m6zOOFylbeCJqk5+pHWvzYPziyZiYoo=
72-
github.com/jmespath/go-jmespath/internal/testify v1.5.1 h1:shLQSRRSCCPj3f2gpwzGwWFoC7ycTf1rcQZHOlsJ6N8=
73-
github.com/jmespath/go-jmespath/internal/testify v1.5.1/go.mod h1:L3OGu8Wl2/fWfCI6z80xFu9LTZmf1ZRjMHUOPmWr69U=
74100
github.com/josharian/intern v1.0.0 h1:vlS4z54oSdjm0bgjRigI+G1HpF+tI+9rE5LLzOg8HmY=
75101
github.com/josharian/intern v1.0.0/go.mod h1:5DoeVV0s6jJacbCEi61lwdGj/aVlrQvzHFFd8Hwg//Y=
76102
github.com/json-iterator/go v1.1.12 h1:PV8peI4a0ysnczrg+LtxykD8LfKY9ML6u2jnxaEnrnM=

pkg/resource/queue/hooks.go

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ import (
1919

2020
ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
2121
ackrtlog "github.com/aws-controllers-k8s/runtime/pkg/runtime/log"
22+
svcsdk "github.com/aws/aws-sdk-go-v2/service/sqs"
2223
"github.com/aws/aws-sdk-go/aws/arn"
23-
svcsdk "github.com/aws/aws-sdk-go/service/sqs"
2424
)
2525

2626
// syncTags examines the Tags in the supplied Queue and calls the
@@ -34,35 +34,35 @@ func (rm *resourceManager) syncTags(
3434
rlog := ackrtlog.FromContext(ctx)
3535
exit := rlog.Trace("rm.syncTags")
3636
defer func() { exit(err) }()
37-
toAdd := map[string]*string{}
38-
toDelete := []*string{}
37+
toAdd := map[string]string{}
38+
toDelete := []string{}
3939

4040
existingTags := latest.ko.Spec.Tags
4141

4242
for k, v := range desired.ko.Spec.Tags {
4343
if ev, found := existingTags[k]; !found || *ev != *v {
44-
toAdd[k] = v
44+
toAdd[k] = *v
4545
}
4646
}
4747

4848
for k, _ := range existingTags {
4949
if _, found := desired.ko.Spec.Tags[k]; !found {
5050
deleteKey := k
51-
toDelete = append(toDelete, &deleteKey)
51+
toDelete = append(toDelete, deleteKey)
5252
}
5353
}
5454

5555
if len(toAdd) > 0 {
5656
for k, v := range toAdd {
57-
rlog.Debug("adding tag to queue", "key", k, "value", *v)
57+
rlog.Debug("adding tag to queue", "key", k, "value", v)
5858
}
5959
if err = rm.addTags(ctx, desired, toAdd); err != nil {
6060
return err
6161
}
6262
}
6363
if len(toDelete) > 0 {
6464
for _, k := range toDelete {
65-
rlog.Debug("removing tag from queue", "key", *k)
65+
rlog.Debug("removing tag from queue", "key", k)
6666
}
6767
if err = rm.removeTags(ctx, desired, toDelete); err != nil {
6868
return err
@@ -76,7 +76,7 @@ func (rm *resourceManager) syncTags(
7676
func (rm *resourceManager) getTags(
7777
ctx context.Context,
7878
r *resource,
79-
) (map[string]*string, error) {
79+
) (map[string]string, error) {
8080
var err error
8181
var resp *svcsdk.ListQueueTagsOutput
8282
rlog := ackrtlog.FromContext(ctx)
@@ -88,7 +88,7 @@ func (rm *resourceManager) getTags(
8888

8989
// NOTE(jaypipes): Unlike many other ListTags APIs, SQS's is not
9090
// paginated...
91-
resp, err = rm.sdkapi.ListQueueTagsWithContext(ctx, input)
91+
resp, err = rm.sdkapi.ListQueueTags(ctx, input)
9292
rm.metrics.RecordAPICall("READ_MANY", "ListQueueTags", err)
9393
if err != nil || resp == nil {
9494
return nil, err
@@ -102,7 +102,7 @@ func (rm *resourceManager) getTags(
102102
func (rm *resourceManager) addTags(
103103
ctx context.Context,
104104
r *resource,
105-
tags map[string]*string,
105+
tags map[string]string,
106106
) (err error) {
107107
rlog := ackrtlog.FromContext(ctx)
108108
exit := rlog.Trace("rm.addTag")
@@ -112,7 +112,7 @@ func (rm *resourceManager) addTags(
112112
input.QueueUrl = r.ko.Status.QueueURL
113113
input.Tags = tags
114114

115-
_, err = rm.sdkapi.TagQueueWithContext(ctx, input)
115+
_, err = rm.sdkapi.TagQueue(ctx, input)
116116
rm.metrics.RecordAPICall("UPDATE", "TagQueue", err)
117117
return err
118118
}
@@ -121,7 +121,7 @@ func (rm *resourceManager) addTags(
121121
func (rm *resourceManager) removeTags(
122122
ctx context.Context,
123123
r *resource,
124-
tagKeys []*string, // the set of tag keys to delete
124+
tagKeys []string, // the set of tag keys to delete
125125
) (err error) {
126126
rlog := ackrtlog.FromContext(ctx)
127127
exit := rlog.Trace("rm.removeTag")
@@ -131,7 +131,7 @@ func (rm *resourceManager) removeTags(
131131
input.QueueUrl = r.ko.Status.QueueURL
132132
input.TagKeys = tagKeys
133133

134-
_, err = rm.sdkapi.UntagQueueWithContext(ctx, input)
134+
_, err = rm.sdkapi.UntagQueue(ctx, input)
135135
rm.metrics.RecordAPICall("UPDATE", "UntagQueue", err)
136136
return err
137137
}

0 commit comments

Comments
 (0)