Skip to content

Fix PreferredBackupWindow not updating #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

Fix PreferredBackupWindow not updating #226

merged 1 commit into from
Jun 11, 2025

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented Jun 6, 2025

Issue #, if available: 2512

Description of changes:

  • Fix type in delta check in newCustomUpdateRequestPayload()
  • Add test verifying PreferredBackupkWindow is correctly included in update input
  • Add .vscode to .gitignore

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@knottnt
Fix PreferredBackupWindow not updating
84be121 
- Fix type in delta check in newCustomUpdateRequestPayload()
- Add test verifying PreferredBackupkWindow is correctly included in update input
- Add .vscode to .gitignore
@ack-prow ack-prow bot requested review from jlbutler and rushmash91 June 6, 2025 23:32
@ack-prow ack-prow bot added the approved label Jun 6, 2025
@knottnt knottnt requested review from a-hilaly and removed request for jlbutler June 6, 2025 23:32
@ack-prow
Copy link

ack-prow bot commented Jun 6, 2025

@knottnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rds-verify-attribution 84be121 link false /test rds-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rushmash91
rushmash91 approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@rushmash91 rushmash91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @knottnt !!
/lgtm

pkg/resource/db_cluster/custom_update.go
}
if desired.ko.Spec.PreferredBackupWindow != nil && delta.DifferentAt("Spec.PreferredBackupkWindow") {
if desired.ko.Spec.PreferredBackupWindow != nil && delta.DifferentAt("Spec.PreferredBackupWindow") {
res.PreferredBackupWindow = desired.ko.Spec.PreferredBackupWindow
Copy link
Member

@rushmash91 rushmash91 Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@ack-prow
Copy link

ack-prow bot commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 0bc6c82 into aws-controllers-k8s:main Jun 11, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rushmash91 rushmash91 rushmash91 approved these changes

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees

@rushmash91 rushmash91

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@knottnt @rushmash91