Enhance RouteTable CRD sync routes synchronisation
#199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `syncRoutes` method to handle errors from `excludeAWSRoute` - Reorder route deletion and addition in `syncRoutes` for proper sync - Modify `excludeAWSRoute` to return an error and rename variables for clarity - Move tags sync before routes sync in `customUpdateRouteTable` - Update `sdkCreate` to use a copy of the RouteTable for creating routes - Minor formatting and comment updates in template files The changes in this commit enhance the synchronization of routes for the RouteTable Custom Resource Definition (CRD). The `syncRoutes` method now handles errors returned from the `excludeAWSRoute` function and reorders the deletion and addition of routes for proper synchronization. The `excludeAWSRoute` function is modified to return an error and has some variable renaming for better clarity... In the `customUpdateRouteTable` method the tags synchronization is moved before the routes synchronization to ensure tagss are updated before route changes. The `sdkCreate` method now uses a deep copy of the RouteTable when creating routes to avoid modifying the original desired state
a-hilaly
changed the title
RouteTable CRD sync routes synchronisation
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nnbu
pushed a commit
to nnbu/ack-ec2-controller
that referenced
this pull request
Sep 18, 2024
…-k8s#199) - Update `syncRoutes` method to handle errors from `excludeAWSRoute` - Reorder route deletion and addition in `syncRoutes` for proper sync - Modify `excludeAWSRoute` to return an error and rename variables for clarity - Move tags sync before routes sync in `customUpdateRouteTable` - Update `sdkCreate` to use a copy of the RouteTable for creating routes - Minor formatting and comment updates in template files The changes in this commit enhance the synchronization of routes for the RouteTable Custom Resource Definition (CRD). The `syncRoutes` method now handles errors returned from the `excludeAWSRoute` function and reorders the deletion and addition of routes for proper synchronization. The `excludeAWSRoute` function is modified to return an error and has some variable renaming for better clarity... In the `customUpdateRouteTable` method the tags synchronization is moved before the routes synchronization to ensure tagss are updated before route changes. The `sdkCreate` method now uses a deep copy of the RouteTable when creating routes to avoid modifying the original desired state By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syncRoutesmethod to handle errors fromexcludeAWSRoutesyncRoutesfor proper syncexcludeAWSRouteto return an error and rename variables for claritycustomUpdateRouteTablesdkCreateto use a copy of the RouteTable for creating routesThe changes in this commit enhance the synchronization of routes for the
RouteTable Custom Resource Definition (CRD). The
syncRoutesmethod now handleserrors returned from the
excludeAWSRoutefunction and reorders the deletionand addition of routes for proper synchronization. The
excludeAWSRoutefunction is modified to return an error and has some variable renaming for
better clarity...
In the
customUpdateRouteTablemethod the tags synchronization is moved beforethe routes synchronization to ensure tagss are updated before route changes.
The
sdkCreatemethod now uses a deep copy of the RouteTable when creatingroutes to avoid modifying the original desired state
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.