Remove runtime checks and leave it to the plugin (#909)

Author: kddejong

src/rpdk/core/project.py

@@ -67,27 +67,13 @@
 
 CFN_METADATA_FILENAME = ".cfn_metadata.json"
 
-LAMBDA_RUNTIMES = {
-    "noexec",  # cannot be executed, schema only
-    "java8",
-    "java11",
-    "go1.x",
-    "python3.6",
-    "python3.7",
-    "python3.8",
-    "dotnetcore2.1",
-    "nodejs10.x",
-    "nodejs12.x",
-    "nodejs14.x",
-}
-
 SETTINGS_VALIDATOR = Draft7Validator(
     {
         "properties": {
             "artifact_type": {"type": "string"},
             "language": {"type": "string"},
             "typeName": {"type": "string", "pattern": TYPE_NAME_RESOURCE_REGEX},
-            "runtime": {"type": "string", "enum": list(LAMBDA_RUNTIMES)},
+            "runtime": {"type": "string"},
             "entrypoint": {"type": ["string", "null"]},
             "testEntrypoint": {"type": ["string", "null"]},
             "executableEntrypoint": {"type": ["string", "null"]},
@@ -114,7 +100,7 @@
             "artifact_type": {"type": "string"},
             "language": {"type": "string"},
             "typeName": {"type": "string", "pattern": TYPE_NAME_HOOK_REGEX},
-            "runtime": {"type": "string", "enum": list(LAMBDA_RUNTIMES)},
+            "runtime": {"type": "string"},
             "entrypoint": {"type": ["string", "null"]},
             "testEntrypoint": {"type": ["string", "null"]},
             "settings": {"type": "object"},
@@ -339,12 +325,6 @@ def _write_example_inputs(self):
             )
 
     def write_settings(self):
-        if self.runtime not in LAMBDA_RUNTIMES:
-            LOG.critical(
-                "Plugin returned invalid runtime: %s (%s)", self.runtime, self.language
-            )
-            raise InternalError("Internal error (Plugin returned invalid runtime)")
-
         def _write_resource_settings(f):
             executable_entrypoint_dict = (
                 {"executableEntrypoint": self.executable_entrypoint}

tests/test_project.py

@@ -30,7 +30,6 @@
 from rpdk.core.project import (
     CFN_METADATA_FILENAME,
     CONFIGURATION_SCHEMA_UPLOAD_FILENAME,
-    LAMBDA_RUNTIMES,
     OVERRIDES_FILENAME,
     SCHEMA_UPLOAD_FILENAME,
     SETTINGS_FILENAME,
@@ -53,7 +52,22 @@
 HOOK_TYPE_NAME = "AWS::CFN::HOOK"
 REGION = "us-east-1"
 ENDPOINT = "cloudformation.beta.com"
-RUNTIME = random.choice(list(LAMBDA_RUNTIMES))
+RUNTIME = random.choice(
+    [
+        "noexec",  # cannot be executed, schema only
+        "java8",
+        "java11",
+        "go1.x",
+        "python3.7",
+        "python3.8",
+        "python3.9",
+        "dotnetcore2.1",
+        "nodejs10.x",
+        "nodejs12.x",
+        "nodejs14.x",
+        "nodejs16.x",
+    ]
+)
 BLANK_CLIENT_ERROR = {"Error": {"Code": "", "Message": ""}}
 LOG = logging.getLogger(__name__)
 REGISTRATION_TOKEN = "foo"
@@ -2132,14 +2146,6 @@ def test__wait_for_registration_waiter_fails_describe_fails(project):
     mock_waiter.wait.assert_called_once_with(RegistrationToken=REGISTRATION_TOKEN)
 
 
-def test__write_settings_invalid_runtime(project):
-    project.runtime = "foo"
-    project.language = LANGUAGE
-
-    with pytest.raises(InternalError):
-        project.write_settings()
-
-
 @pytest.mark.parametrize(
     "docs_schema",
     (