From 8afbac36f168be03d3bfe198722ec4b414d9fb26 Mon Sep 17 00:00:00 2001 From: Michael Maeng Date: Mon, 7 Nov 2022 13:15:01 -0500 Subject: [PATCH 1/2] Removed pip update command from docker build artifacts in cfn submit --- python/rpdk/python/codegen.py | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/python/rpdk/python/codegen.py b/python/rpdk/python/codegen.py index dd4b61c..9c19f7f 100644 --- a/python/rpdk/python/codegen.py +++ b/python/rpdk/python/codegen.py @@ -246,17 +246,6 @@ def _build(self, base_path): self._pip_build(base_path) LOG.debug("Dependencies build finished") - @staticmethod - def _update_pip_command(): - return [ - "python", - "-m", - "pip", - "install", - "--upgrade", - "pip", - ] - @staticmethod def _make_pip_command(base_path): return [ @@ -281,8 +270,6 @@ def _docker_build(cls, external_path): internal_path = PurePosixPath("/project") command = ( '/bin/bash -c "' - + " ".join(cls._update_pip_command()) - + " && " + " ".join(cls._make_pip_command(internal_path)) + '"' ) From fa13d86027c36b10cd8c020459c972a3ffe40d6d Mon Sep 17 00:00:00 2001 From: Michael Maeng Date: Mon, 7 Nov 2022 13:23:54 -0500 Subject: [PATCH 2/2] formatting and linting --- python/rpdk/python/codegen.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/python/rpdk/python/codegen.py b/python/rpdk/python/codegen.py index 9c19f7f..76b085e 100644 --- a/python/rpdk/python/codegen.py +++ b/python/rpdk/python/codegen.py @@ -269,9 +269,7 @@ def _get_plugin_information() -> Dict: def _docker_build(cls, external_path): internal_path = PurePosixPath("/project") command = ( - '/bin/bash -c "' - + " ".join(cls._make_pip_command(internal_path)) - + '"' + '/bin/bash -c "' + " ".join(cls._make_pip_command(internal_path)) + '"' ) LOG.debug("command is '%s'", command)