Skip to content

Commit 9f5eb81

Browse files
committed
More items for python 3.8 and 3.9 support
1 parent 0b27f78 commit 9f5eb81

File tree

4 files changed

+15
-10
lines changed

4 files changed

+15
-10
lines changed

.github/workflows/pr-ci.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
runs-on: ubuntu-latest
1717
strategy:
1818
matrix:
19-
python: [3.6, 3.7, 3.8]
19+
python: [3.6, 3.7, 3.8, 3.9]
2020
steps:
2121
- uses: actions/checkout@v2
2222
- name: Set up Python ${{ matrix.python }}
@@ -36,3 +36,7 @@ jobs:
3636
run: ./e2e-test.sh python36
3737
- name: End to End Resource Packaging Test Python 3.7
3838
run: ./e2e-test.sh python37
39+
- name: End to End Resource Packaging Test Python 3.8
40+
run: ./e2e-test.sh python38
41+
- name: End to End Resource Packaging Test Python 3.9
42+
run: ./e2e-test.sh python39

e2e-test.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@ DIR=$(mktemp -d)
33
cd "$DIR"
44
ls -la
55
cfn init -t AWS::Foo::Bar -a RESOURCE $1 --use-docker
6+
cat rpdk.log
67
ls -la
78
mypy src/aws_foo_bar/ --strict --implicit-reexport

python/rpdk/python/parser.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
def setup_subparser(subparsers, parents, python_version):
1+
def setup_subparser(subparsers, parents, python_version, python_version_number):
22
parser = subparsers.add_parser(
33
python_version,
4-
description="""This sub command generates IDE and build files for Python {}
5-
""".format(
6-
"3.6" if python_version == "python36" else "3.7"
4+
description=(
5+
"This sub command generates IDE and build files for Python "
6+
"{}".format(python_version_number)
77
),
88
parents=parents,
99
)
@@ -22,16 +22,16 @@ def setup_subparser(subparsers, parents, python_version):
2222

2323

2424
def setup_subparser_python36(subparsers, parents):
25-
return setup_subparser(subparsers, parents, "python36")
25+
return setup_subparser(subparsers, parents, "python36", "3.6")
2626

2727

2828
def setup_subparser_python37(subparsers, parents):
29-
return setup_subparser(subparsers, parents, "python37")
29+
return setup_subparser(subparsers, parents, "python37", "3.7")
3030

3131

3232
def setup_subparser_python38(subparsers, parents):
33-
return setup_subparser(subparsers, parents, "python38")
33+
return setup_subparser(subparsers, parents, "python38", "3.8")
3434

3535

3636
def setup_subparser_python39(subparsers, parents):
37-
return setup_subparser(subparsers, parents, "python39")
37+
return setup_subparser(subparsers, parents, "python39", "3.9")

src/cloudformation_cli_python_lib/log_delivery.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def __init__(
2424
self.group = group
2525
self.stream = stream.replace(":", "__")
2626
self.client = session.client("logs")
27-
self.sequence_token = ""
27+
self.sequence_token = "" # nosec
2828

2929
@classmethod
3030
def _get_existing_logger(cls) -> Optional["ProviderLogHandler"]:

0 commit comments

Comments
 (0)