Some initial valgrind cleanup

Finalize the MCA param subsystem to cleanup the
parameter storage. Provide a way to release the
pmix_value_t and pmix_data_array_t storage. Ensure
we release the pmix_job_t tracker in the gds/hash
component when the nspace is deleted.

Resolve memory corruption problem associated with passing
the HWLOC topology into the PMIx server from the host. This
was being copied during the "info_list" processing, and then
being deleted when the resulting data array was released - leaving
the server to continue accessing the free'd topology tree.

Remove an unnecessary "retain" - thanks to Artem Polyakov for
spotting it. Cleanup around that to avoid segfault of double
release while avoiding leak.

Add some missing utility finalize calls

Signed-off-by: Ralph Castain <[email protected]>

Author: rhc54

include/pmix.h

@@ -1087,6 +1087,8 @@ PMIX_EXPORT pmix_status_t PMIx_Parse_cpuset_string(const char *cpuset_string,
 
 PMIX_EXPORT pmix_status_t PMIx_Get_cpuset(pmix_cpuset_t *cpuset, pmix_bind_envelope_t ref);
 
+PMIX_EXPORT void PMIx_Cpuset_destruct(pmix_cpuset_t *cpuset);
+
 /* Get the relative locality of two local processes given their locality strings.
  *
  * locality1 - String returned by the PMIx_server_generate_locality_string API
@@ -1580,6 +1582,8 @@ PMIX_EXPORT pmix_status_t PMIx_Value_unload(pmix_value_t *val,
                                             void **data,
                                             size_t *sz);
 
+PMIX_EXPORT void PMIx_Value_destruct(pmix_value_t *val);
+
 /* Transfer data from one pmix_value_t to another - this is actually
  * executed as a COPY operation, so the original data is not altered.
  */
@@ -1590,6 +1594,8 @@ PMIX_EXPORT pmix_status_t PMIx_Value_xfer(pmix_value_t *dest,
 PMIX_EXPORT pmix_value_cmp_t PMIx_Value_compare(pmix_value_t *v1,
                                                 pmix_value_t *v2);
 
+PMIX_EXPORT void PMIx_Data_array_destruct(pmix_data_array_t *d);
+
 /* Load key/value data into a pmix_info_t struct. Note that this
  * effectively is a PMIX_LOAD_KEY operation to copy the key,
  * followed by a PMIx_Value_load to COPY the data into the
@@ -1623,6 +1629,8 @@ PMIX_EXPORT pmix_status_t PMIx_Info_list_add(void *ptr,
                                              const void *value,
                                              pmix_data_type_t type);
 
+PMIX_EXPORT pmix_status_t PMIx_Info_list_insert(void *ptr, pmix_info_t *info);
+
 /* Transfer the data in an existing pmix_info_t struct to a list. This
  * is executed as a COPY operation, so the original data is not altered.
  * The "ptr" passed here is the pointer returned by PMIx_Info_list_start