Only apply power-assert to new t.assert() assertion

Author: eemed

docs/03-assertions.md

@@ -84,7 +84,7 @@ test('skip assertion', t => {
 
 ## Enhanced assertion messages
 
-AVA comes with [`power-assert`](https://github.com/power-assert-js/power-assert) built-in, giving you more descriptive assertion messages. It reads your test and tries to infer more information from the code.
+AVA comes with [`power-assert`](https://github.com/power-assert-js/power-assert) built-in, giving you more descriptive assertion messages.
 
 Let's take this example, using Node's standard [`assert` library](https://nodejs.org/api/assert.html):
 
@@ -101,24 +101,48 @@ If you paste that into a Node REPL it'll return:
 AssertionError: false == true
 ```
 
-In AVA however, this test:
+With AVA's `assert` assertion however, this test:
 
 ```js
 test('enhanced assertions', t => {
 	const a = /foo/;
 	const b = 'bar';
 	const c = 'baz';
-	t.true(a.test(b) || b === c);
+	t.assert(a.test(b) || b === c);
 });
 ```
 
 Will output:
 
 ```
-t.true(a.test(b) || b === c)
-       |      |     |     |
-       |      "bar" "bar" "baz"
-       false
+6:   const c = 'baz';
+7:   t.assert(a.test(b) || b === c);
+8: });
+
+Value is not truthy:
+
+false
+
+a.test(b) || b === c
+=> false
+
+b === c
+=> false
+
+c
+=> 'baz'
+
+b
+=> 'bar'
+
+a.test(b)
+=> false
+
+b
+=> 'bar'
+
+a
+=> /foo/
 ```
 
 ## Custom assertions
@@ -147,6 +171,10 @@ Passing assertion.
 
 Failing assertion.
 
+### `.assert(value, [message])`
+
+Asserts that `value` is truthy. This is [`power-assert`](#enhanced-assertion-messages) enabled.
+
 ### `.truthy(value, [message])`
 
 Assert that `value` is truthy.

docs/06-configuration.md

@@ -57,8 +57,8 @@ Arguments passed to the CLI will always take precedence over the CLI options con
 - `tap`: if `true`, enables the [TAP reporter](./05-command-line.md#tap-reporter)
 - `verbose`: if `true`, enables verbose output
 - `snapshotDir`: specifies a fixed location for storing snapshot files. Use this if your snapshots are ending up in the wrong location
-- `compileEnhancements`: if `false`, disables [power-assert](https://github.com/power-assert-js/power-assert) — which otherwise helps provide more descriptive error messages — and detection of improper use of the `t.throws()` assertion
-- `extensions`: extensions of test files that are not precompiled using AVA's Babel presets. Note that files are still compiled to enable power-assert and other features, so you may also need to set `compileEnhancements` to `false` if your files are not valid JavaScript. Setting this overrides the default `"js"` value, so make sure to include that extension in the list, as long as it's not included in `babel.extensions`
+- `compileEnhancements`: if `false`, disables [`power-assert`](./03-assertions.md#enhanced-assertion-messages) — which otherwise helps provide more descriptive error messages — and detection of improper use of the `t.throws()` assertion
+- `extensions`: extensions of test files that are not precompiled using AVA's Babel presets. Note that files are still compiled to enable `power-assert` and other features, so you may also need to set `compileEnhancements` to `false` if your files are not valid JavaScript. Setting this overrides the default `"js"` value, so make sure to include that extension in the list, as long as it's not included in `babel.extensions`
 - `require`: extra modules to require before tests are run. Modules are required in the [worker processes](./01-writing-tests.md#process-isolation)
 - `babel`: test file specific Babel options. See our [Babel recipe](./recipes/babel.md#configuring-babel) for more details
 - `babel.extensions`: extensions of test files that will be precompiled using AVA's Babel presets. Setting this overrides the default `"js"` value, so make sure to include that extension in the list

docs/08-common-pitfalls.md

@@ -75,11 +75,11 @@ AVA [can't trace uncaught exceptions](https://github.com/avajs/ava/issues/214) b
 
 ### Why are the enhanced assertion messages not shown?
 
-Ensure that the first parameter passed into your test is named `t`. This is a requirement of [`power-assert`](https://github.com/power-assert-js/power-assert), the library that provides the enhanced messages.
+Ensure that the first parameter passed into your test is named `t`. This is a requirement of [`power-assert`](https://github.com/power-assert-js/power-assert), the library that provides the [enhanced messages](./03-assertions.md#enhanced-assertion-messages).
 
 ```js
 test('one is one', t => {
-	t.is(1, 1);
+	t.assert(1 === 1);
 });
 ```
 

lib/assert.js

@@ -589,110 +589,139 @@ function wrapAssertions(callbacks) {
 					message: message || 'No snapshot available, run with --update-snapshots'
 				}));
 			}
-		}
-	};
+		},
 
-	const enhancedAssertions = enhanceAssert(pass, fail, {
 		truthy(actual, message) {
-			if (!actual) {
-				throw new AssertionError({
+			if (actual) {
+				pass(this);
+			} else {
+				fail(this, new AssertionError({
 					assertion: 'truthy',
 					message,
 					operator: '!!',
 					values: [formatWithLabel('Value is not truthy:', actual)]
-				});
+				}));
 			}
 		},
 
 		falsy(actual, message) {
 			if (actual) {
-				throw new AssertionError({
+				fail(this, new AssertionError({
 					assertion: 'falsy',
 					message,
 					operator: '!',
 					values: [formatWithLabel('Value is not falsy:', actual)]
-				});
+				}));
+			} else {
+				pass(this);
 			}
 		},
 
 		true(actual, message) {
-			if (actual !== true) {
-				throw new AssertionError({
+			if (actual === true) {
+				pass(this);
+			} else {
+				fail(this, new AssertionError({
 					assertion: 'true',
 					message,
 					values: [formatWithLabel('Value is not `true`:', actual)]
-				});
+				}));
 			}
 		},
 
 		false(actual, message) {
-			if (actual !== false) {
-				throw new AssertionError({
+			if (actual === false) {
+				pass(this);
+			} else {
+				fail(this, new AssertionError({
 					assertion: 'false',
 					message,
 					values: [formatWithLabel('Value is not `false`:', actual)]
-				});
+				}));
 			}
 		},
 
 		regex(string, regex, message) {
 			if (typeof string !== 'string') {
-				throw new AssertionError({
+				fail(this, new AssertionError({
 					assertion: 'regex',
 					improperUsage: true,
 					message: '`t.regex()` must be called with a string',
 					values: [formatWithLabel('Called with:', string)]
-				});
+				}));
+				return;
 			}
 
 			if (!(regex instanceof RegExp)) {
-				throw new AssertionError({
+				fail(this, new AssertionError({
 					assertion: 'regex',
 					improperUsage: true,
 					message: '`t.regex()` must be called with a regular expression',
 					values: [formatWithLabel('Called with:', regex)]
-				});
+				}));
+				return;
 			}
 
 			if (!regex.test(string)) {
-				throw new AssertionError({
+				fail(this, new AssertionError({
 					assertion: 'regex',
 					message,
 					values: [
 						formatWithLabel('Value must match expression:', string),
 						formatWithLabel('Regular expression:', regex)
 					]
-				});
+				}));
+				return;
 			}
+
+			pass(this);
 		},
 
 		notRegex(string, regex, message) {
 			if (typeof string !== 'string') {
-				throw new AssertionError({
+				fail(this, new AssertionError({
 					assertion: 'notRegex',
 					improperUsage: true,
 					message: '`t.notRegex()` must be called with a string',
 					values: [formatWithLabel('Called with:', string)]
-				});
+				}));
+				return;
 			}
 
 			if (!(regex instanceof RegExp)) {
-				throw new AssertionError({
+				fail(this, new AssertionError({
 					assertion: 'notRegex',
 					improperUsage: true,
 					message: '`t.notRegex()` must be called with a regular expression',
 					values: [formatWithLabel('Called with:', regex)]
-				});
+				}));
+				return;
 			}
 
 			if (regex.test(string)) {
-				throw new AssertionError({
+				fail(this, new AssertionError({
 					assertion: 'notRegex',
 					message,
 					values: [
 						formatWithLabel('Value must not match expression:', string),
 						formatWithLabel('Regular expression:', regex)
 					]
+				}));
+				return;
+			}
+
+			pass(this);
+		}
+	};
+
+	const enhancedAssertions = enhanceAssert(pass, fail, {
+		assert(actual, message) {
+			if (!actual) {
+				throw new AssertionError({
+					assertion: 'assert',
+					message,
+					operator: '!!',
+					values: [formatWithLabel('Value is not truthy:', actual)]
 				});
 			}
 		}

lib/enhance-assert.js

@@ -8,12 +8,7 @@ const concordanceOptions = require('./concordance-options').default;
 // https://github.com/avajs/babel-preset-transform-test-files/blob/master/espower-patterns.json
 // Then release a new version of that preset and bump the SemVer range here.
 const PATTERNS = [
-	't.truthy(value, [message])',
-	't.falsy(value, [message])',
-	't.true(value, [message])',
-	't.false(value, [message])',
-	't.regex(contents, regex, [message])',
-	't.notRegex(contents, regex, [message])'
+	't.assert(value, [message])'
 ];
 
 const computeStatement = node => generate(node).code;

media/magic-assert-combined.png

@@ -0,0 +1,11 @@
+{
+  "name": "screenshot-fixtures",
+  "version": "1.0.0",
+  "description": "",
+  "main": "magic-assert-buffers.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "keywords": [],
+  "author": ""
+}