Skip to content

Conversation

@PaulaSp3
Copy link
Contributor

@PaulaSp3 PaulaSp3 commented Aug 6, 2025

  • There is a new parameter in the (local_)com4FlowPyCfg.ini outputNoDataValue (default: -9999) that defines the nodata value for the output rasters
  • Then ALL output rasters have the same value in cells taht are not affected by the process (default -9999)
  • I've tested in one example, if all -9999 values are at the same locations in every output-raster.
  • A further question/ issue?: Should we initialize the rasterArrays consistently? (see Issue#1165)

@PaulaSp3 PaulaSp3 requested a review from ahuber-bfw August 6, 2025 13:07
@PaulaSp3 PaulaSp3 self-assigned this Aug 6, 2025
@PaulaSp3 PaulaSp3 added enhancement New feature or request flowPyDev Ideas for future development labels Aug 6, 2025
@fso42 fso42 added this to the Version 1.13 milestone Aug 7, 2025
@fso42 fso42 modified the milestones: Version 1.13, Version 1.14 Aug 21, 2025
@PaulaSp3 PaulaSp3 force-pushed the PS_FP_outputNanValues branch from 8fdf1a5 to 4a4ed46 Compare August 28, 2025 14:57
@ahuber-bfw
Copy link
Contributor

ahuber-bfw commented Aug 28, 2025

Maybe changes are only necessary in com4FlowPyCfg.ini, runCom4FlowPy.py and com4FlowPy.py if we simply provide the cell_counts raster to the defineNotAffectedCells() function in com4FlowPy.mergeAndWriteResults()

sth. like zDelta = defineNotAffectedCells(raster = zDelta, affectedCells = cellCounts, noDataValue = _outputNoDataValue)

Copy link
Contributor

@ahuber-bfw ahuber-bfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and a lot more compact now :)

Maybe we can wait for PR #1173 to be merged and then also resolve issue #1178 in this PR? (adding an .ini option for disabling .tif compression) $\rightarrow$ this would also only require minor changes to (local)com4FlowPyCfg.ini, runCom4FlowPy.py and com4FlowPy.py

regarding issue #1165 I need to have a closer look still ;) - so maybe could be included in a further PR.

@PaulaSp3 PaulaSp3 force-pushed the PS_FP_outputNanValues branch from 6e34a98 to 89a7362 Compare September 11, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request flowPyDev Ideas for future development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[com4FlowPy] - handing of "non-affected" areas/cell in com4FlowPy output rasters

4 participants