fix(rlp): Nillable() decoding into field pointer

ARR4N · ARR4N · commit dbc7ce0df969 · 2025-02-06T11:01:19.000Z
diff --git a/core/types/rlp_backwards_compat.libevm_test.go b/core/types/rlp_backwards_compat.libevm_test.go
@@ -248,12 +248,14 @@ func TestBodyRLPCChainCompat(t *testing.T) {
 		wantRLPHex string
 	}{
 		{
+			name: "nil ExtData",
 			extra: &cChainBodyExtras{
 				Version: version,
 			},
 			wantRLPHex: `e5dedd2a80809400000000000000000000000000decafc0ffeebad8080808080c08304cb2f80`,
 		},
 		{
+			name: "non-nil ExtData",
 			extra: &cChainBodyExtras{
 				Version: version,
 				ExtData: &[]byte{1, 4, 2, 8, 5, 7},
diff --git a/rlp/list.libevm.go b/rlp/list.libevm.go
@@ -183,7 +183,7 @@ func (n *nillable[T]) DecodeRLP(s *Stream) error {
 		return err
 	}
 	if size > 0 {
-		return s.Decode(*n.v)
+		return s.Decode(n.v)
 	}
 	*n.v = nil
 	_, err = s.Raw() // consume the item

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ func (n nillable[T]) DecodeRLP(s Stream) error {`
`183`	`183`	`return err`
`184`	`184`	`}`
`185`	`185`	`if size > 0 {`
`186`		`- return s.Decode(*n.v)`
	`186`	`+ return s.Decode(n.v)`
`187`	`187`	`}`
`188`	`188`	`*n.v = nil`
`189`	`189`	`_, err = s.Raw() // consume the item`