Security #1: Attempt to bump up generic-array
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The linked report does not exist: 404. |
Collaborator
Author
|
|
Collaborator
Author
|
What about now? |
tmplt
requested changes
Jul 25, 2022
Member
tmplt
left a comment
tmplt
left a comment
There was a problem hiding this comment.
Still can't access the report. But both dep bumps LGTM. I'd rewrite the commit:
cargo: bump nb, cortex-m
nb bumped due to <link to report>.
or similar.
hal/Cargo.toml
Outdated
| [package] | ||
| name = "atsamx7x-hal" | ||
| version = "0.1.0" | ||
| version = "0.2.0" |
Member
There was a problem hiding this comment.
Techically, a MINOR bump is overkill. A PATCH bump suffices.
|
|
||
| [dependencies] | ||
| cortex-m = "0.7" | ||
| cortex-m = "0.7.5" |
Member
There was a problem hiding this comment.
Commit does not mention a cortex-m bump.
michalfita
force-pushed
the
security/1/bump-up-dependencies-to-once-using-newer-generic-array
branch
from
32bb559 to
a2b53ef
Compare
tmplt
approved these changes
Jul 27, 2022
michalfita
deleted the
security/1/bump-up-dependencies-to-once-using-newer-generic-array
branch
michalfita
restored the
security/1/bump-up-dependencies-to-once-using-newer-generic-array
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses report from dependabot: https://github.com/atsams-rs/atsamx7x-rust/security/dependabot/1