fix #2680

steven nguyen · web-flow · commit bf6d625e8bcf · 2021-05-13T22:31:39.000-05:00
https://reactjs.org/docs/react-component.html#shouldcomponentupdate `UNSAFE_componentWillReceiveProps`: https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops
diff --git a/lib/atom/commands.js b/lib/atom/commands.js
@@ -53,9 +53,9 @@ export class Command extends React.Component {
     this.observeTarget(this.props);
   }
 
-  componentWillReceiveProps(newProps) {
-    if (['registry', 'target', 'command', 'callback'].some(p => newProps[p] !== this.props[p])) {
-      this.observeTarget(newProps);
+  componentDidUpdate(prevProps) {
+    if (['registry', 'target', 'command', 'callback'].some(p => prevProps[p] !== this.props[p])) {
+      this.observeTarget(this.props);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -53,9 +53,9 @@ export class Command extends React.Component {`
`53`	`53`	`this.observeTarget(this.props);`
`54`	`54`	`}`
`55`	`55`
`56`		`- componentWillReceiveProps(newProps) {`
`57`		`- if (['registry', 'target', 'command', 'callback'].some(p => newProps[p] !== this.props[p])) {`
`58`		`- this.observeTarget(newProps);`
	`56`	`+ componentDidUpdate(prevProps) {`
	`57`	`+ if (['registry', 'target', 'command', 'callback'].some(p => prevProps[p] !== this.props[p])) {`
	`58`	`+ this.observeTarget(this.props);`
`59`	`59`	`}`
`60`	`60`	`}`
`61`	`61`