Skip to content

Conversation

@ErnestoLoma
Copy link
Contributor

@ErnestoLoma ErnestoLoma commented Aug 14, 2025

✨ Description

Modify the AtlanClient.from_token_guid method to include optional parameters for base_url, client_id, and client_secret. These parameters should fall back to the configured environment variables if not provided.

Jira link: APP-8170


🧩 Type of change

Select all that apply:

  • [ X] 🚀 New feature (non-breaking change that adds functionality)
  • 🐛 Bug fix (non-breaking change that fixes an issue) — please include tests! Refer testing-toolkit 🧪
  • 🔄 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🧹 Maintenance (chores, cleanup, minor improvements)
  • 💥 Breaking change (fix or feature that may break existing functionality)
  • 📦 Dependency upgrade/downgrade
  • 📚 Documentation updates

✅ How has this been tested? (e.g. screenshots, logs, workflow links)

Describe how the change was tested. Include:

  • Steps to reproduce
  • Any relevant screenshots, logs, or links to successful workflow runs
  • Details on environment/setup if applicable

📋 Checklist

  • My code follows the project’s style guidelines
  • I’ve performed a self-review of my code
  • I’ve added comments in tricky or complex areas
  • I’ve updated the documentation as needed
  • There are no new warnings from my changes
  • I’ve added tests to cover my changes
  • All new and existing tests pass locally

@ErnestoLoma ErnestoLoma requested a review from Aryamanz29 August 14, 2025 20:09
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Aryamanz29 Aryamanz29 merged commit fcefbdc into main Aug 18, 2025
54 of 58 checks passed
@Aryamanz29 Aryamanz29 deleted the APP-8170 branch August 18, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants