MAINT: adding workaround for astropy type hints #3327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
=======================================
Coverage 69.87% 69.87%
=======================================
Files 232 232
Lines 19769 19770 +1
=======================================
+ Hits 13814 13815 +1
Misses 5955 5955 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pllim
reviewed
May 29, 2025
| nitpicky = True | ||
| nitpick_ignore = [('py:class', 'astroquery.mast.core.MastQueryWithLogin')] | ||
| nitpick_ignore = [('py:class', 'astroquery.mast.core.MastQueryWithLogin'), | ||
| # astropy interited type annotations |
Member
There was a problem hiding this comment.
Belated comment: interited -> inherited
Member
There was a problem hiding this comment.
It is unfortunate this is needed but I see that Marten already commented upstream. Thanks!
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so sphinx doesn't choke on them here
closes #3326
This can be merged once RTD is passing build