Skip to content

Windows CI failing after latest GHA update #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zanieb opened this issue Oct 21, 2024 · 4 comments · Fixed by #377
Closed

Windows CI failing after latest GHA update #376

zanieb opened this issue Oct 21, 2024 · 4 comments · Fixed by #377

Comments

@zanieb
Copy link
Member

zanieb commented Oct 21, 2024

I presume this is caused by a GHA bump

https://github.com/actions/runner-images/releases/tag/win19%2F20241015.1

A successful build (on the old runner image)

2024-10-16T20:43:49.9341964Z cpython>        FindVCRedistDir:
2024-10-16T20:43:49.9343225Z cpython>          VC Redist Directory: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\\Redist\MSVC\14.29.30133\x64\
2024-10-16T20:43:49.9344590Z cpython>          VC Redist Version: 14.29.30133
2024-10-16T20:43:49.9739128Z cpython>        FindVCRuntime:
2024-10-16T20:43:49.9740432Z cpython>          VC Runtime DLL(s):
2024-10-16T20:43:49.9742801Z cpython>          - C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.29.30133\x64\Microsoft.VC142.CRT\vcruntime140.dll
2024-10-16T20:43:49.9745498Z cpython>          - C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.29.30133\x64\Microsoft.VC142.CRT\vcruntime140_1.dll

and a failing build (on the new runner image)

2024-10-21T17:20:23.9829945Z cpython>        (FindVCRuntime target) ->
2024-10-21T17:20:23.9833336Z cpython>          C:\Users\RUNNER~1\AppData\Local\Temp\python-build-1xvutigs\Python-3.9.20\PCbuild\pyproject.props(225,5): warning : vcruntime*.dll not found under C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\\Redist\MSVC\14.29.30156\x86\. [C:\Users\RUNNER~1\AppData\Local\Temp\python-build-1xvutigs\Python-3.9.20\PCbuild\pythoncore.vcxproj]
@zanieb
Copy link
Member Author

zanieb commented Oct 21, 2024

Perhaps related actions/runner-images#10819

@zanieb
Copy link
Member Author

zanieb commented Oct 21, 2024

There was also a change to the Cygwin setup files on Oct 20

Various problems also being reported at https://sourceware.org/pipermail/cygwin/2024-October/256601.html

@indygreg
Copy link
Collaborator

We should consider upgrading to latest Visual Studio compiler. Assuming CPython supports it. It should support it since the Microsoft C/C++ compiler tends to be very backwards compatible. The only issue we might run into is the Microsoft Visual C++ Runtime DLL. But I want to say there aren't impactful changes from upgrading.

@zanieb
Copy link
Member Author

zanieb commented Oct 29, 2024

Upgrading in #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants