feat(31): add assertion for NonEmptyList<A> type #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks, man 🙏. I'll review it in the next few days. |
rcardin
requested changes
Sep 10, 2024
Collaborator
rcardin
left a comment
rcardin
left a comment
There was a problem hiding this comment.
I made some minor comments. Can you please address them? Let me know if anything is unclear.
src/main/kotlin/in/rcard/assertj/arrowcore/NonEmptyListAssert.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/in/rcard/assertj/arrowcore/AbstractNonEmptyListAssert.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/in/rcard/assertj/arrowcore/AbstractNonEmptyListAssert.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/in/rcard/assertj/arrowcore/AbstractNonEmptyListAssert.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/in/rcard/assertj/arrowcore/AbstractNonEmptyListAssert.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/in/rcard/assertj/arrowcore/errors/NonEmptyListDoesNotContain.kt
Show resolved
Hide resolved
src/main/kotlin/in/rcard/assertj/arrowcore/errors/NonEmptyListDoesNotContainOnly.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/in/rcard/assertj/arrowcore/errors/NonEmptyListDoesNotHaveSingleElementEqual.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/in/rcard/assertj/arrowcore/errors/NonEmptyListHasNoDuplicates.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/in/rcard/assertj/arrowcore/errors/NonEmptyListIsNotSorted.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the feedback @rcardin, I will update the PR accordingly in the next few days as soon as I'm available :) |
rcardin
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements assertions for
NonEmptyList<A>type as specified in #31, the implemented assertions are:shouldContainshouldContainAllshouldContainNullshouldContainNoNullsshouldContainOnlyNullsshouldHaveDuplicatesshouldBeSingleElementshouldBeSortedTake a look @rcardin and let me know if something needs improvement 😉