Skip to content
This repository was archived by the owner on Oct 18, 2018. It is now read-only.

Add guardrails to prevent users from upgrading out of the shared framework #1192

Closed
natemcmaster opened this issue May 31, 2018 · 1 comment
Assignees
Labels
cost: L Will take 6 - 10 days to complete investigate Investigation item Servicing-consider Shiproom approval is required for the issue wontfix

Comments

@natemcmaster
Copy link
Contributor

Follow-up to #1180

Originally, we intended to use package version constraints as a guardrail to prevent users from hoisting out of the shared framework. This caused enough usability issues that we removed this guardrail in 2.1.1 in #1186.

There are other ways we could implement the guardrails, such as abusing the platform manifest trimming in the SDK. See #1180 (comment) for details. We should investigate more if this is something we can do in 2.1.3

cc @davidfowl @DamianEdwards

@natemcmaster
Copy link
Contributor Author

After lots of internal investigation and discussion, I do not believe we have yet found a good, working proposal for implementing guardrails. The variety of complex scenarios surrounding ref and runtime assembly versioning creates too much risk for a patch. We will explore alternatives.

cref discussion here: https://github.com/aspnet/specs/pull/172

@natemcmaster natemcmaster removed this from the 2.1.3 milestone Aug 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cost: L Will take 6 - 10 days to complete investigate Investigation item Servicing-consider Shiproom approval is required for the issue wontfix
Projects
None yet
Development

No branches or pull requests

1 participant