This repository was archived by the owner on Nov 21, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
Kestrel config binder should understand * and localhost #73
Comments
@muratg @DamianEdwards @Eilon We chatted about this one and we think we need to get this into preview1. @muratg please assign. |
We chatted even more and the fix is more complicated than we want to take right now. We'll have to tell folks to browse to localhost. |
Assigning to @CesarBS for post preview2. |
@glennc This issue is also the first in a series of issue that prevents enabling docker for out templates that use authentication. |
Note this code is moving to Kestrel. aspnet/KestrelHttpServer#1878 |
This issue was moved to aspnet/KestrelHttpServer#1879 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The templates are going to enable SSL via config in dev and production. They need to set up the rest of the endpoints when they do this. #44 added the ability to bind to IPs and ports, but that makes for a poor user experience. In dev the templates want localhost, but will have to specify 127.0.0.1 (and ::1) if they want IPv6 support. In production they'll need to specify a public IP (0.0.0.0 and ::0).
Config should allow
localhost
that binds to 127.0.0.1 and ::1, and * that binds to 0.0.0.0 and ::0, using the same logic that kestrel applies to UseUrls values. Even better, implement this in Kestrel with a Listen that takes the string ip/host so you don't have to duplicate all of the logic.The text was updated successfully, but these errors were encountered: