Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Kestrel config binder should understand * and localhost #73

Closed
Tratcher opened this issue Apr 27, 2017 · 7 comments
Closed

Kestrel config binder should understand * and localhost #73

Tratcher opened this issue Apr 27, 2017 · 7 comments
Assignees
Labels
Milestone

Comments

@Tratcher
Copy link
Member

The templates are going to enable SSL via config in dev and production. They need to set up the rest of the endpoints when they do this. #44 added the ability to bind to IPs and ports, but that makes for a poor user experience. In dev the templates want localhost, but will have to specify 127.0.0.1 (and ::1) if they want IPv6 support. In production they'll need to specify a public IP (0.0.0.0 and ::0).

Config should allow localhost that binds to 127.0.0.1 and ::1, and * that binds to 0.0.0.0 and ::0, using the same logic that kestrel applies to UseUrls values. Even better, implement this in Kestrel with a Listen that takes the string ip/host so you don't have to duplicate all of the logic.

@Tratcher
Copy link
Member Author

@danroth27

@danroth27 danroth27 added this to the 2.0.0-preview1 milestone May 5, 2017
@danroth27
Copy link
Member

@muratg @DamianEdwards @Eilon We chatted about this one and we think we need to get this into preview1. @muratg please assign.

@danroth27 danroth27 added the bug label May 5, 2017
@danroth27
Copy link
Member

We chatted even more and the fix is more complicated than we want to take right now. We'll have to tell folks to browse to localhost.

@muratg muratg modified the milestones: 2.0.0-preview3, 2.0.0-preview2 May 25, 2017
@muratg
Copy link

muratg commented May 25, 2017

Assigning to @CesarBS for post preview2.

@danroth27
Copy link
Member

@glennc This issue is also the first in a series of issue that prevents enabling docker for out templates that use authentication.

@Tratcher
Copy link
Member Author

Tratcher commented Jun 1, 2017

Note this code is moving to Kestrel. aspnet/KestrelHttpServer#1878

@danroth27
Copy link
Member

This issue was moved to aspnet/KestrelHttpServer#1879

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants