Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Optimize BeginScope to avoid having to pass a pre-calculated string to it #261

Closed
DamianEdwards opened this issue Oct 8, 2015 · 2 comments
Closed

Optimize BeginScope to avoid having to pass a pre-calculated string to it #261

DamianEdwards opened this issue Oct 8, 2015 · 2 comments
Assignees
@lodejard
Labels
Perf
Milestone
1.0.0-rc2

Comments

@DamianEdwards
Copy link
Member

This will avoid having to create strings for the scope message before a log message is ever logged. This currently shows up in the profiles for the plaintext benchmark.

@lodejard is putting together a design PR for this.
@DamianEdwards DamianEdwards added this to the 1.0.0-rc1 milestone Oct 8, 2015
@lodejard lodejard mentioned this issue Oct 15, 2015
Closed
@kichalla kichalla assigned lodejard and unassigned kichalla Oct 19, 2015
@muratg
Copy link

muratg commented Oct 26, 2015

Just talked to @lodejard. Moving is issues to RC2.

@muratg muratg modified the milestones: 1.0.0-rc2, 1.0.0-rc1 Oct 26, 2015
@lodejard
Copy link
Contributor

Closed, this is implemented by ilogger's define messages and lazy evaluation of string message and trace identifier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lodejard lodejard

Labels
Perf
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
4 participants
@DamianEdwards @lodejard @muratg @kichalla