Always log messages and never throw

pakrym · pakrym · commit b1ac0836bda2 · 2017-04-03T13:41:27.000-07:00
diff --git a/src/Microsoft.Extensions.Logging.Console/Internal/ConsoleLoggerProcessor.cs b/src/Microsoft.Extensions.Logging.Console/Internal/ConsoleLoggerProcessor.cs
@@ -29,8 +29,16 @@ public virtual void EnqueueMessage(LogMessageEntry message)
         {
             if (!_messageQueue.IsAddingCompleted)
             {
-                _messageQueue.Add(message);
+                try
+                {
+                    _messageQueue.Add(message);
+                    return;
+                }
+                catch (InvalidOperationException) { }
             }
+
+            // Adding is completed so just log the message
+            WriteMessage(message);
         }
 
         // for testing

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,16 @@ public virtual void EnqueueMessage(LogMessageEntry message)`
`29`	`29`	`{`
`30`	`30`	`if (!_messageQueue.IsAddingCompleted)`
`31`	`31`	`{`
`32`		`- _messageQueue.Add(message);`
	`32`	`+ try`
	`33`	`+ {`
	`34`	`+ _messageQueue.Add(message);`
	`35`	`+ return;`
	`36`	`+ }`
	`37`	`+ catch (InvalidOperationException) { }`
`33`	`38`	`}`
	`39`	`+`
	`40`	`+ // Adding is completed so just log the message`
	`41`	`+ WriteMessage(message);`
`34`	`42`	`}`
`35`	`43`
`36`	`44`	`// for testing`