Always log messages and never throw

Author: pakrym

src/Microsoft.Extensions.Logging.Console/Internal/ConsoleLoggerProcessor.cs

@@ -29,8 +29,16 @@ public virtual void EnqueueMessage(LogMessageEntry message)
         {
             if (!_messageQueue.IsAddingCompleted)
             {
-                _messageQueue.Add(message);
+                try
+                {
+                    _messageQueue.Add(message);
+                    return;
+                }
+                catch (InvalidOperationException) { }
             }
+
+            // Adding is completed so just log the message
+            WriteMessage(message);
         }
 
         // for testing

test/Microsoft.Extensions.Logging.Test/ConsoleLoggerTest.cs

@@ -836,15 +836,21 @@ public void WriteCore_NullMessageWithNullException()
         }
 
         [Fact]
-        public void LogAfterDisposeDoesNotThrow()
+        public void LogAfterDisposeWritesLog()
         {
+            // Arrange
             var sink = new ConsoleSink();
             var console = new TestConsole(sink);
             var processor = new ConsoleLoggerProcessor();
             var logger = new ConsoleLogger(_loggerName, filter: null, includeScopes: false, loggerProcessor: processor);
             logger.Console = console;
+
+            // Act
             processor.Dispose();
             logger.LogInformation("Logging after dispose");
+
+            // Assert
+            Assert.True(sink.Writes.Count == 2);
         }
 
         private string GetMessage(string logLevelString, int eventId, Exception exception)