Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Path should be unescaped #124

Closed
lodejard opened this issue Jul 8, 2015 · 5 comments
Closed

Path should be unescaped #124

lodejard opened this issue Jul 8, 2015 · 5 comments
Assignees
Milestone

Comments

@lodejard
Copy link
Contributor

lodejard commented Jul 8, 2015

Not sure if kestrel is doing this yet, but the path portion (not the query portion) of the request line should be unescaped.

@glennc glennc added this to the 1.0.0-beta8 milestone Aug 11, 2015
@muratg muratg modified the milestones: 1.0.0-rc1, 1.0.0-beta8 Sep 23, 2015
@muratg muratg assigned troydai and unassigned halter73 Oct 13, 2015
@troydai
Copy link
Contributor

troydai commented Oct 13, 2015

I'm validating current Kestrel behavior

@troydai
Copy link
Contributor

troydai commented Oct 15, 2015

Looks like an issue:

send:

http://localhost:5000/path(%201)/path2?key=value%202&key2=value2

kestrel:

GET /path(%25201)/path2?key=value%202&key2=value2

@Tratcher
Copy link
Member

Compare to weblistener. We should also check what happens when behind IIS.

@troydai
Copy link
Contributor

troydai commented Oct 16, 2015

To: @Tratcher @lodejard @halter73 @blowdart

Note:

  • I'll add the logic to https://github.com/aspnet/HttpAbstractions/tree/dev/src/Microsoft.Extensions.WebEncoders.Core so as to able to share the path decoding loigc
  • Different from Http.Sys, %2F will not be unescaped so as not to alter the meaning of an Url path.

@troydai
Copy link
Contributor

troydai commented Oct 23, 2015

Fixed in 52f4fa9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants