Implement IHeaderDictionary.ContentLength

Author: benaadams

src/Microsoft.AspNetCore.Server.Kestrel/BadHttpRequestException.cs

@@ -43,6 +43,9 @@ internal static BadHttpRequestException GetException(RequestRejectionReason reas
                 case RequestRejectionReason.MalformedRequestInvalidHeaders:
                     ex = new BadHttpRequestException("Malformed request: invalid headers.", StatusCodes.Status400BadRequest);
                     break;
+                case RequestRejectionReason.MultipleContentLengths:
+                    ex = new BadHttpRequestException("Multiple Content-Length headers.", StatusCodes.Status400BadRequest);
+                    break;
                 case RequestRejectionReason.UnexpectedEndOfRequestContent:
                     ex = new BadHttpRequestException("Unexpected end of request content.", StatusCodes.Status400BadRequest);
                     break;

src/Microsoft.AspNetCore.Server.Kestrel/Internal/Http/Frame.cs

@@ -41,7 +41,6 @@ public abstract partial class Frame : IFrameControl
         private static readonly byte[] _bytesConnectionKeepAlive = Encoding.ASCII.GetBytes("\r\nConnection: keep-alive");
         private static readonly byte[] _bytesTransferEncodingChunked = Encoding.ASCII.GetBytes("\r\nTransfer-Encoding: chunked");
         private static readonly byte[] _bytesHttpVersion11 = Encoding.ASCII.GetBytes("HTTP/1.1 ");
-        private static readonly byte[] _bytesContentLengthZero = Encoding.ASCII.GetBytes("\r\nContent-Length: 0");
         private static readonly byte[] _bytesEndHeaders = Encoding.ASCII.GetBytes("\r\n\r\n");
         private static readonly byte[] _bytesServer = Encoding.ASCII.GetBytes("\r\nServer: Kestrel");
 
@@ -657,12 +656,12 @@ private void VerifyAndUpdateWrite(int count)
 
             if (responseHeaders != null &&
                 !responseHeaders.HasTransferEncoding &&
-                responseHeaders.HasContentLength &&
-                _responseBytesWritten + count > responseHeaders.HeaderContentLengthValue.Value)
+                responseHeaders.ContentLength.HasValue &&
+                _responseBytesWritten + count > responseHeaders.ContentLength.Value)
             {
                 _keepAlive = false;
                 throw new InvalidOperationException(
-                    $"Response Content-Length mismatch: too many bytes written ({_responseBytesWritten + count} of {responseHeaders.HeaderContentLengthValue.Value}).");
+                    $"Response Content-Length mismatch: too many bytes written ({_responseBytesWritten + count} of {responseHeaders.ContentLength.Value}).");
             }
 
             _responseBytesWritten += count;
@@ -679,8 +678,8 @@ private void CheckLastWrite()
             // Called after VerifyAndUpdateWrite(), so _responseBytesWritten has already been updated.
             if (responseHeaders != null &&
                 !responseHeaders.HasTransferEncoding &&
-                responseHeaders.HasContentLength &&
-                _responseBytesWritten == responseHeaders.HeaderContentLengthValue.Value)
+                responseHeaders.ContentLength.HasValue &&
+                _responseBytesWritten == responseHeaders.ContentLength.Value)
             {
                 _abortedCts = null;
             }
@@ -692,8 +691,8 @@ protected void VerifyResponseContentLength()
 
             if (!HttpMethods.IsHead(Method) &&
                 !responseHeaders.HasTransferEncoding &&
-                responseHeaders.HeaderContentLengthValue.HasValue &&
-                _responseBytesWritten < responseHeaders.HeaderContentLengthValue.Value)
+                responseHeaders.ContentLength.HasValue &&
+                _responseBytesWritten < responseHeaders.ContentLength.Value)
             {
                 // We need to close the connection if any bytes were written since the client
                 // cannot be certain of how many bytes it will receive.
@@ -703,7 +702,7 @@ protected void VerifyResponseContentLength()
                 }
 
                 ReportApplicationError(new InvalidOperationException(
-                    $"Response Content-Length mismatch: too few bytes written ({_responseBytesWritten} of {responseHeaders.HeaderContentLengthValue.Value})."));
+                    $"Response Content-Length mismatch: too few bytes written ({_responseBytesWritten} of {responseHeaders.ContentLength.Value})."));
             }
         }
 
@@ -920,13 +919,13 @@ private void CreateResponseHeader(
             // automatically for HEAD requests or 204, 205, 304 responses.
             if (_canHaveBody)
             {
-                if (!hasTransferEncoding && !responseHeaders.HasContentLength)
+                if (!hasTransferEncoding && !responseHeaders.ContentLength.HasValue)
                 {
                     if (appCompleted && StatusCode != StatusCodes.Status101SwitchingProtocols)
                     {
                         // Since the app has completed and we are only now generating
                         // the headers we can safely set the Content-Length to 0.
-                        responseHeaders.SetRawContentLength("0", _bytesContentLengthZero);
+                        responseHeaders.ContentLength = 0;
                     }
                     else
                     {
@@ -1468,7 +1467,7 @@ private void SetErrorResponseHeaders(int statusCode)
             var dateHeaderValues = DateHeaderValueManager.GetDateHeaderValues();
 
             responseHeaders.SetRawDate(dateHeaderValues.String, dateHeaderValues.Bytes);
-            responseHeaders.SetRawContentLength("0", _bytesContentLengthZero);
+            responseHeaders.ContentLength = 0;
 
             if (ServerOptions.AddServerHeader)
             {