Chunk non-keepalive HTTP/1.1 responses.

Author: Cesar Blum Silveira

src/Microsoft.AspNetCore.Server.Kestrel/Internal/Http/Frame.cs

@@ -781,7 +781,7 @@ private void CreateResponseHeader(
                         // the headers we can safely set the Content-Length to 0.
                         responseHeaders.SetRawContentLength("0", _bytesContentLengthZero);
                     }
-                    else if (_keepAlive)
+                    else
                     {
                         // Note for future reference: never change this to set _autoChunk to true on HTTP/1.0
                         // connections, even if we were to infer the client supports it because an HTTP/1.0 request

test/Microsoft.AspNetCore.Server.KestrelTests/ChunkedResponseTests.cs

@@ -5,6 +5,7 @@
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Testing;
 using Xunit;
 
@@ -67,9 +68,8 @@ public async Task ResponsesAreNotChunkedAutomaticallyForHttp10Requests(TestServi
         {
             using (var server = new TestServer(async httpContext =>
             {
-                var response = httpContext.Response;
-                await response.Body.WriteAsync(Encoding.ASCII.GetBytes("Hello "), 0, 6);
-                await response.Body.WriteAsync(Encoding.ASCII.GetBytes("World!"), 0, 6);
+                await httpContext.Response.WriteAsync("Hello ");
+                await httpContext.Response.WriteAsync("World!");
             }, testContext))
             {
                 using (var connection = server.CreateConnection())
@@ -89,13 +89,14 @@ await connection.ReceiveEnd(
             }
         }
 
-        public async Task ResponsesAreNotChunkedAutomaticallyForHttp11NonKeepAliveRequests(TestServiceContext testContext)
+        [Theory]
+        [MemberData(nameof(ConnectionFilterData))]
+        public async Task ResponsesAreChunkedAutomaticallyForHttp11NonKeepAliveRequests(TestServiceContext testContext)
         {
             using (var server = new TestServer(async httpContext =>
             {
-                var response = httpContext.Response;
-                await response.Body.WriteAsync(Encoding.ASCII.GetBytes("Hello "), 0, 6);
-                await response.Body.WriteAsync(Encoding.ASCII.GetBytes("World!"), 0, 6);
+                await httpContext.Response.WriteAsync("Hello ");
+                await httpContext.Response.WriteAsync("World!");
             }, testContext))
             {
                 using (var connection = server.CreateConnection())
@@ -109,22 +110,28 @@ await connection.ReceiveEnd(
                         "HTTP/1.1 200 OK",
                         "Connection: close",
                         $"Date: {testContext.DateHeaderValue}",
+                        "Transfer-Encoding: chunked",
                         "",
-                        "Hello World!");
+                        "6",
+                        "Hello ",
+                        "6",
+                        "World!",
+                        "0",
+                        "",
+                        "");
                 }
             }
         }
 
         [Theory]
         [MemberData(nameof(ConnectionFilterData))]
-        public async Task SettingConnectionCloseHeaderInAppDisablesChunking(TestServiceContext testContext)
+        public async Task SettingConnectionCloseHeaderInAppDoesNotDisableChunking(TestServiceContext testContext)
         {
             using (var server = new TestServer(async httpContext =>
             {
-                var response = httpContext.Response;
-                response.Headers["Connection"] = "close";
-                await response.Body.WriteAsync(Encoding.ASCII.GetBytes("Hello "), 0, 6);
-                await response.Body.WriteAsync(Encoding.ASCII.GetBytes("World!"), 0, 6);
+                httpContext.Response.Headers["Connection"] = "close";
+                await httpContext.Response.WriteAsync("Hello ");
+                await httpContext.Response.WriteAsync("World!");
             }, testContext))
             {
                 using (var connection = server.CreateConnection())
@@ -137,8 +144,15 @@ await connection.ReceiveEnd(
                         "HTTP/1.1 200 OK",
                         "Connection: close",
                         $"Date: {testContext.DateHeaderValue}",
+                        "Transfer-Encoding: chunked",
                         "",
-                        "Hello World!");
+                        "6",
+                        "Hello ",
+                        "6",
+                        "World!",
+                        "0",
+                        "",
+                        "");
                 }
             }
         }