Avoid unecessary allocation for RawTarget.

Author: Cesar Blum Silveira

src/Microsoft.AspNetCore.Server.Kestrel/Http/Frame.cs

@@ -851,7 +851,7 @@ protected RequestLineStatus TakeStartLine(SocketInput input)
                     queryString = begin.GetAsciiString(scan);
                 }
 
-                var rawTarget = pathBegin.GetAsciiString(scan);
+                var queryEnd = scan;
 
                 if (pathBegin.Peek() == ' ')
                 {
@@ -900,8 +900,12 @@ protected RequestLineStatus TakeStartLine(SocketInput input)
                 // Multibyte Internationalized Resource Identifiers (IRIs) are first converted to utf8;
                 // then encoded/escaped to ASCII  https://www.ietf.org/rfc/rfc3987.txt "Mapping of IRIs to URIs"
                 string requestUrlPath;
+                string rawTarget;
                 if (needDecode)
                 {
+                    // Read raw target before mutating memory.
+                    rawTarget = pathBegin.GetAsciiString(queryEnd);
+
                     // URI was encoded, unescape and then parse as utf8
                     pathEnd = UrlPathDecoder.Unescape(pathBegin, pathEnd);
                     requestUrlPath = pathBegin.GetUtf8String(pathEnd);
@@ -911,6 +915,17 @@ protected RequestLineStatus TakeStartLine(SocketInput input)
                 {
                     // URI wasn't encoded, parse as ASCII
                     requestUrlPath = pathBegin.GetAsciiString(pathEnd);
+
+                    if (queryString.Length == 0)
+                    {
+                        // No need to allocate an extra string if the path didn't need
+                        // decoding and there's no query string following it.
+                        rawTarget = requestUrlPath;
+                    }
+                    else
+                    {
+                        rawTarget = pathBegin.GetAsciiString(queryEnd);
+                    }
                 }
 
                 requestUrlPath = PathNormalizer.RemoveDotSegments(requestUrlPath);

test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/project.json

@@ -11,22 +11,22 @@
     "xunit": "2.1.0"
   },
   "frameworks": {
-    "netcoreapp1.0": {
-      "dependencies": {
-        "Microsoft.NETCore.App": {
-          "version": "1.0.0-*",
-          "type": "platform"
-        },
-        "System.Net.Http": "4.0.1-*",
-        "System.Net.Http.WinHttpHandler": "4.0.0-*",
-        "System.Runtime.Serialization.Primitives": "4.1.1-*"
-      },
-      "imports": [
-        "portable-dnxcore50+net45+win8+wp8+wpa81",
-        "dotnet",
-        "portable-net45+win8"
-      ]
-    },
+    //"netcoreapp1.0": {
+    //  "dependencies": {
+    //    "Microsoft.NETCore.App": {
+    //      "version": "1.0.0-*",
+    //      "type": "platform"
+    //    },
+    //    "System.Net.Http": "4.0.1-*",
+    //    "System.Net.Http.WinHttpHandler": "4.0.0-*",
+    //    "System.Runtime.Serialization.Primitives": "4.1.1-*"
+    //  },
+    //  "imports": [
+    //    "portable-dnxcore50+net45+win8+wp8+wpa81",
+    //    "dotnet",
+    //    "portable-net45+win8"
+    //  ]
+    //},
     "net451": {
       "dependencies": {
         "xunit.runner.console": "2.1.0"