Precompute Http Version bytes

Author: benaadams

src/Microsoft.AspNet.Server.Kestrel/Http/Frame.cs

@@ -32,6 +32,8 @@ public partial class Frame : FrameContext, IFrameControl
         private static readonly byte[] _bytesConnectionClose = Encoding.ASCII.GetBytes("Connection: close\r\n\r\n");
         private static readonly byte[] _bytesConnectionKeepAlive = Encoding.ASCII.GetBytes("Connection: keep-alive\r\n\r\n");
         private static readonly byte[] _bytesTransferEncodingChunked = Encoding.ASCII.GetBytes("Transfer-Encoding: chunked\r\n");
+        private static readonly byte[] _bytesHttpVersion1_0 = Encoding.ASCII.GetBytes("HTTP/1.0 ");
+        private static readonly byte[] _bytesHttpVersion1_1 = Encoding.ASCII.GetBytes("HTTP/1.1 ");
         private static readonly byte[] _bytesContentLengthZero = Encoding.ASCII.GetBytes("Content-Length: 0\r\n");
         private static readonly byte[] _bytesSpace = Encoding.ASCII.GetBytes(" ");
 
@@ -53,6 +55,8 @@ public partial class Frame : FrameContext, IFrameControl
         private bool _keepAlive;
         private bool _autoChunk;
         private Exception _applicationException;
+        
+        private HttpVersionType _httpVersion;
 
         private readonly IPEndPoint _localEndPoint;
         private readonly IPEndPoint _remoteEndPoint;
@@ -78,7 +82,36 @@ public Frame(ConnectionContext context,
         public string RequestUri { get; set; }
         public string Path { get; set; }
         public string QueryString { get; set; }
-        public string HttpVersion { get; set; }
+        public string HttpVersion
+        {
+            get
+            {
+                if (_httpVersion == HttpVersionType.Http1_1)
+                {
+                    return "HTTP/1.1";
+                }
+                if (_httpVersion == HttpVersionType.Http1_0)
+                {
+                    return "HTTP/1.0";
+                }
+                return "";
+            }
+            set
+            {
+                if (value == "HTTP/1.1")
+                {
+                    _httpVersion = HttpVersionType.Http1_1;
+                }
+                else if (value == "HTTP/1.0")
+                {
+                    _httpVersion = HttpVersionType.Http1_0;
+                }
+                else
+                {
+                    _httpVersion = HttpVersionType.Unknown;
+                }
+            }
+        }
         public IHeaderDictionary RequestHeaders { get; set; }
         public MessageBody MessageBody { get; set; }
         public Stream RequestBody { get; set; }
@@ -113,7 +146,7 @@ public void Reset()
             RequestUri = null;
             Path = null;
             QueryString = null;
-            HttpVersion = null;
+            _httpVersion = HttpVersionType.Unknown;
             RequestHeaders = _requestHeaders;
             MessageBody = null;
             RequestBody = null;
@@ -454,7 +487,7 @@ public void ProduceContinue()
             if (_responseStarted) return;
 
             StringValues expect;
-            if (HttpVersion.Equals("HTTP/1.1") &&
+            if (_httpVersion == HttpVersionType.Http1_1 &&
                 RequestHeaders.TryGetValue("Expect", out expect) &&
                 (expect.FirstOrDefault() ?? "").Equals("100-continue", StringComparison.OrdinalIgnoreCase))
             {
@@ -575,8 +608,8 @@ private Task CreateResponseHeader(
             {
                 var blockRemaining = memoryBlock.Data.Count;
 
-                OutputAsciiBlock(HttpVersion, memoryBlock, SocketOutput);
-                OutputAsciiBlock(_bytesSpace, memoryBlock, SocketOutput);
+                OutputAsciiBlock(_httpVersion == HttpVersionType.Http1_1 ? _bytesHttpVersion1_1 : _bytesHttpVersion1_0, memoryBlock, SocketOutput);
+
                 OutputAsciiBlock(statusBytes, memoryBlock, SocketOutput);
 
                 foreach (var header in _responseHeaders.AsOutputEnumerable())
@@ -610,7 +643,7 @@ private Task CreateResponseHeader(
                     }
                     else
                     {
-                        if (HttpVersion == "HTTP/1.1")
+                        if (_httpVersion == HttpVersionType.Http1_1)
                         {
                             _autoChunk = true;
                             OutputAsciiBlock(_bytesTransferEncodingChunked, memoryBlock, SocketOutput);
@@ -622,11 +655,11 @@ private Task CreateResponseHeader(
                     }
                 }
 
-                if (_keepAlive == false && _responseHeaders.HasConnection == false && HttpVersion == "HTTP/1.1")
+                if (_keepAlive == false && _responseHeaders.HasConnection == false && _httpVersion == HttpVersionType.Http1_1)
                 {
                     OutputAsciiBlock(_bytesConnectionClose, memoryBlock, SocketOutput);
                 }
-                else if (_keepAlive && _responseHeaders.HasConnection == false && HttpVersion == "HTTP/1.0")
+                else if (_keepAlive && _responseHeaders.HasConnection == false && _httpVersion == HttpVersionType.Http1_0)
                 {
                     OutputAsciiBlock(_bytesConnectionKeepAlive, memoryBlock, SocketOutput);
                 }
@@ -849,5 +882,12 @@ private void ReportApplicationError(Exception ex)
             _applicationException = ex;
             Log.ApplicationError(ex);
         }
+
+        private enum HttpVersionType
+        {
+            Unknown = -1,
+            Http1_0 = 0,
+            Http1_1 = 1
+        }
     }
 }

src/Microsoft.AspNet.Server.Kestrel/Http/FrameHeaders.cs

@@ -12,16 +12,16 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
 {
     public abstract class FrameHeaders : IHeaderDictionary
     {
+        protected Dictionary<string, StringValues> MaybeUnknown;
+
+        protected Dictionary<string, StringValues> Unknown => MaybeUnknown ?? (MaybeUnknown = new Dictionary<string, StringValues>(StringComparer.OrdinalIgnoreCase));
+
         public bool HasConnection { get; protected set; }
 
         public bool HasTransferEncoding { get; protected set; }
 
         public bool HasContentLength { get; protected set; }
 
-        protected Dictionary<string, StringValues> MaybeUnknown;
-
-        protected Dictionary<string, StringValues> Unknown => MaybeUnknown ?? (MaybeUnknown = new Dictionary<string, StringValues>(StringComparer.OrdinalIgnoreCase));
-
         StringValues IHeaderDictionary.this[string key]
         {
             get