Cleanup

Author: Tratcher

src/Kestrel/EndpointConfiguration.cs

@@ -14,13 +14,13 @@ internal EndpointConfiguration(bool isHttps, ListenOptions listenOptions, HttpsC
         {
             IsHttps = isHttps;
             Listener = listenOptions ?? throw new ArgumentNullException(nameof(listenOptions));
-            Https = httpsOptions;
+            Https = httpsOptions ?? throw new ArgumentNullException(nameof(httpsOptions));
             ConfigSection = configSection ?? throw new ArgumentNullException(nameof(configSection));
         }
 
         public bool IsHttps { get; }
         public ListenOptions Listener { get; }
-        public HttpsConnectionAdapterOptions Https { get; set; }
+        public HttpsConnectionAdapterOptions Https { get; }
         public IConfigurationSection ConfigSection { get; }
     }
 }

src/Kestrel/Internal/ConfigurationReader.cs

@@ -117,20 +117,20 @@ public CertificateConfig(IConfigurationSection configSection)
         // File
         public bool IsFileCert => !string.IsNullOrEmpty(Path);
 
-        public string Path => ConfigSection?["Path"];
+        public string Path => ConfigSection["Path"];
 
-        public string Password => ConfigSection?["Password"];
+        public string Password => ConfigSection["Password"];
 
         // Cert store
 
         public bool IsStoreCert => !string.IsNullOrEmpty(Subject);
 
-        public string Subject => ConfigSection?["Subject"];
+        public string Subject => ConfigSection["Subject"];
 
-        public string Store => ConfigSection?["Store"];
+        public string Store => ConfigSection["Store"];
 
-        public string Location => ConfigSection?["Location"];
+        public string Location => ConfigSection["Location"];
 
-        public bool? AllowInvalid => ConfigSection?.GetSection("AllowInvalid")?.Get<bool?>();
+        public bool? AllowInvalid => ConfigSection.GetSection("AllowInvalid").Get<bool?>();
     }
 }

test/Kestrel.Tests/KestrelConfigurationBuilderTests.cs

@@ -127,9 +127,6 @@ public void Configure_IsReplacable()
         public void ConfigureDefaultsAppliesToNewConfigureEndpoints()
         {
             var serverOptions = CreateServerOptions();
-            serverOptions.ListenLocalhost(5000);
-
-            Assert.True(serverOptions.ListenOptions[0].NoDelay);
 
             serverOptions.ConfigureEndpointDefaults(opt =>
             {