Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Commit 098e04a

Browse files
committed
Fix issues from rebase
1 parent ffffbe0 commit 098e04a

File tree

11 files changed

+21
-24
lines changed

11 files changed

+21
-24
lines changed

src/Microsoft.AspNet.Server.Kestrel/Http/ConnectionContext.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ public ConnectionContext(ConnectionContext context) : base(context)
1818
SocketInput = context.SocketInput;
1919
SocketOutput = context.SocketOutput;
2020
ConnectionControl = context.ConnectionControl;
21+
DateHeaderValueManager = context.DateHeaderValueManager;
2122
}
2223

2324
public SocketInput SocketInput { get; set; }

src/Microsoft.AspNet.Server.Kestrel/Http/Frame.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public Frame(ConnectionContext context) : base(context)
3838
FrameControl = this;
3939
StatusCode = 200;
4040
RequestHeaders = _requestHeaders;
41-
_responseHeaders = new FrameResponseHeaders(DateHeaderValueManager);
41+
_responseHeaders = new FrameResponseHeaders(DateHeaderValueManager.GetDateHeaderValue());
4242
ResponseHeaders = _responseHeaders;
4343
}
4444

@@ -389,8 +389,8 @@ public void ProduceEnd(Exception ex)
389389
// the app func has failed. https://github.com/aspnet/KestrelHttpServer/issues/43
390390
_onStarting = null;
391391

392-
ResponseHeaders = new FrameResponseHeaders(DateHeaderValueManager);
393-
ResponseHeaders["Content-Length"] = new[] { "0" };
392+
ResponseHeaders = new FrameResponseHeaders(DateHeaderValueManager.GetDateHeaderValue());
393+
ResponseHeaders["Content-Length"] = "0";
394394
}
395395
}
396396

src/Microsoft.AspNet.Server.Kestrel/Http/FrameHeaders.Generated.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public partial class FrameResponseHeaders
1010
public FrameResponseHeaders(string dateHeaderValue)
1111
{
1212
_Server = "Kestrel";
13-
_Date = GetDateHeaderValue();
13+
_Date = dateHeaderValue;
1414
_bits = 67108868L;
1515
}
1616
}

src/Microsoft.AspNet.Server.Kestrel/Http/FrameHeaders.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,4 @@ bool IDictionary<string, StringValues>.TryGetValue(string key, out StringValues
131131
return TryGetValueFast(key, out value);
132132
}
133133
}
134-
private static string GetDateHeaderValue()
135-
{
136-
PumpTimer();
137-
138-
return _dateValue;
139-
}
140134
}

src/Microsoft.AspNet.Server.Kestrel/Http/Listener.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,11 @@ public abstract class Listener : ListenerContext, IDisposable
1515
{
1616
protected Listener(ServiceContext serviceContext) : base(serviceContext)
1717
{
18-
}
1918

20-
protected UvStreamHandle ListenSocket { get; private set; }
21-
public Listener(IMemoryPool memory, DateHeaderValueManager dateHeaderValueManager)
22-
{
23-
Memory = memory;
24-
DateHeaderValueManager = dateHeaderValueManager;
2519
}
2620

21+
protected UvStreamHandle ListenSocket { get; private set; }
22+
2723
public Task StartAsync(
2824
string scheme,
2925
string host,

src/Microsoft.AspNet.Server.Kestrel/Http/ListenerContext.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,15 @@ public ListenerContext() { }
1313
public ListenerContext(ServiceContext serviceContext)
1414
{
1515
Memory = serviceContext.Memory;
16+
DateHeaderValueManager = serviceContext.DateHeaderValueManager;
1617
}
1718

1819
public ListenerContext(ListenerContext listenerContext)
1920
{
2021
Thread = listenerContext.Thread;
2122
Application = listenerContext.Application;
2223
Memory = listenerContext.Memory;
24+
DateHeaderValueManager = listenerContext.DateHeaderValueManager;
2325
}
2426

2527
public KestrelThread Thread { get; set; }

src/Microsoft.AspNet.Server.Kestrel/Http/ListenerSecondary.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public abstract class ListenerSecondary : ListenerContext, IDisposable
1818
{
1919
protected ListenerSecondary(ServiceContext serviceContext) : base(serviceContext)
2020
{
21-
DateHeaderValueManager = dateHeaderValueManager;
21+
2222
}
2323

2424
UvPipeHandle DispatchPipe { get; set; }

src/Microsoft.AspNet.Server.Kestrel/KestrelEngine.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,16 @@ private KestrelEngine(IApplicationShutdown appShutdownService)
7373
_serviceContext = new ServiceContext
7474
{
7575
AppShutdown = appShutdownService,
76-
Memory = new MemoryPool()
76+
Memory = new MemoryPool(),
77+
DateHeaderValueManager = new DateHeaderValueManager()
7778
};
7879

7980
Threads = new List<KestrelThread>();
80-
DateHeaderValueManager = new DateHeaderValueManager();
8181
}
8282

8383
public Libuv Libuv { get; private set; }
84+
8485
public List<KestrelThread> Threads { get; private set; }
85-
public DateHeaderValueManager DateHeaderValueManager { get; private set; }
8686

8787
public void Start(int count)
8888
{
@@ -105,7 +105,7 @@ public void Dispose()
105105
}
106106
Threads.Clear();
107107

108-
DateHeaderValueManager.Dispose();
108+
_serviceContext.DateHeaderValueManager.Dispose();
109109
}
110110

111111
public IDisposable CreateServer(string scheme, string host, int port, Func<Frame, Task> application)

src/Microsoft.AspNet.Server.Kestrel/ServiceContext.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,7 @@ public class ServiceContext
1111
public IApplicationShutdown AppShutdown { get; set; }
1212

1313
public IMemoryPool Memory { get; set; }
14+
15+
public DateHeaderValueManager DateHeaderValueManager { get; set; }
1416
}
1517
}

test/Microsoft.AspNet.Server.KestrelTests/FrameResponseHeadersTests.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ public class FrameResponseHeadersTests
1414
[Fact]
1515
public void InitialDictionaryContainsServerAndDate()
1616
{
17-
IDictionary<string, StringValues> headers = new FrameResponseHeaders();
17+
var dateHeaderValue = DateTime.UtcNow.ToString("r");
18+
IDictionary<string, StringValues> headers = new FrameResponseHeaders(dateHeaderValue);
1819

1920
Assert.Equal(2, headers.Count);
2021

@@ -36,7 +37,8 @@ public void InitialDictionaryContainsServerAndDate()
3637
[Fact]
3738
public void InitialEntriesCanBeCleared()
3839
{
39-
IDictionary<string, StringValues> headers = new FrameResponseHeaders();
40+
var dateHeaderValue = DateTime.UtcNow.ToString("r");
41+
IDictionary<string, StringValues> headers = new FrameResponseHeaders(dateHeaderValue);
4042

4143
headers.Clear();
4244

tools/Microsoft.AspNet.Server.Kestrel.GeneratedCode/KnownHeaders.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ public partial class FrameResponseHeaders
176176
public FrameResponseHeaders(string dateHeaderValue)
177177
{{
178178
_Server = ""Kestrel"";
179-
_Date = GetDateHeaderValue();
179+
_Date = dateHeaderValue;
180180
_bits = {
181181
1L << responseHeaders.First(header => header.Name == "Server").Index |
182182
1L << responseHeaders.First(header => header.Name == "Date").Index

0 commit comments

Comments
 (0)